Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp2638103ybk; Mon, 18 May 2020 04:21:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEc0fgqNz88gGcZOt3rYioZFJFrjV1mUN6BL8qxIUII0UyMfWEK+ecH7aW2PcI8Tj0E370 X-Received: by 2002:a17:906:86d6:: with SMTP id j22mr14649937ejy.1.1589800918750; Mon, 18 May 2020 04:21:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589800918; cv=none; d=google.com; s=arc-20160816; b=mupbyqVkw89KiGAlGD4leu5UMoL8npAU1R7lzyzZiAD/l6YzmLO6RGomI3bngVJf81 ZdGy+lbFBFj9/Fp73i0HKFnOv22PFtIYG/R1SAlhCNEYl7nUrlMWG1WltbtdSfcj9N4R LarM4BIom8Th9IoX9GR/GpRoVpAhNsfuwp4eXGx0Oev6P+xKX93WAichZNKVulj6xfec nsQuIhS4jaMRdLOfLyV+W7Rx5HZfYHxN2JAeIBogDV+xgFMkn+fs3EXTJMyDkPYfoEBa Jw4qmM5BOJReU4JgCp07ASG42At0AyjvwFLX7Uj1vkzz5Z9QSJKvESbxA2XaGDam/KYl FI1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:user-agent:references:in-reply-to:date:cc:to:from :message-id; bh=vjk1fUdzG2gmJTBRXbZd0lzzlFlq7l1GKSmrcJkLNl0=; b=K7f6sUn2h2v5BTRa4uTykNmwoJ2jPrMouu8ExldM3/qP6BpwvgSh0mi+7mzsGzMS63 fiJC0sIhq3E1eHdFUA4tIF45Ex12+nxnjRX1JQmY3EIZ0ERoLRZj8OR2zWXVIejSdWsF hCjwntT0y/RktE6CNSp+YrO4wkY4ZEP/CPULN9skJ+wVoJvYbDJIMRl1ckl4qgaubFnZ dcYAQyWIphTSpjYIsqCk9uYU3dMnPxeslBTmlWvW66LGMNvgHSEdMhCYaKBDAOgzApop UOOYvdvU+OMif6yezpKNGgg72ZC4bCzah5fOH95DzLcvw3LUVlnIQRlSXZwpyZt/uSJN h1RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si6199858eja.225.2020.05.18.04.21.23; Mon, 18 May 2020 04:21:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbgERLVS (ORCPT + 99 others); Mon, 18 May 2020 07:21:18 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:33210 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726499AbgERLVS (ORCPT ); Mon, 18 May 2020 07:21:18 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[192.168.100.69]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jadpb-000cvW-JP; Mon, 18 May 2020 14:21:16 +0300 Message-ID: From: Luca Coelho To: Zhang Rui , linux-pm@vger.kernel.org, gil.adam@intel.com Cc: linux-wireless@vger.kernel.org, daniel.lezcano@linaro.org, andrzej.p@collabora.com, b.zolnierkie@samsung.com Date: Mon, 18 May 2020 14:21:13 +0300 In-Reply-To: <4b6a9dbf43a33354c01d760f7fab3723e5882269.camel@intel.com> References: <20200430063229.6182-1-rui.zhang@intel.com> <20200430063229.6182-2-rui.zhang@intel.com> <4b6a9dbf43a33354c01d760f7fab3723e5882269.camel@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: Re: [PATCH 1/6] iwlwifi: use thermal_zone_device_update() for temperature change Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2020-05-12 at 09:58 +0800, Zhang Rui wrote: > On Thu, 2020-04-30 at 14:32 +0800, Zhang Rui wrote: > > thermal_notify_framework() is an obsolete API, and iwlwifi is the > > only > > user of it. > > Convert iwlwifi driver to use thermal_zone_device_update() instead. > > > > Note that, thermal_zone_device_update() is able to handle the crossed > > threshold by comparing the current temperature with every trip point, > > so > > ths_crossed variant in iwl_mvm_temp_notif() is probably not needed. > > It is still left there in this patch, in case the debug information > > is > > still needed. > > > > Signed-off-by: Zhang Rui > > Hi, Luca, > > Any comments about this patch and patch 6/6? Hi Rui, Sorry for the delay, we have been making some small changes in this code to support a new interface with our firmware and I wanted to make sure things work together. I'm adding Gil, who is making the changes, to this thread so he can also take a look. -- Cheers, Luca.