Received: by 2002:a17:90a:bc8d:0:0:0:0 with SMTP id x13csp1519048pjr; Mon, 18 May 2020 15:17:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySTEh9UYe8T3/6b+Zd3+SB5fFAjJNGNGhLn6w7a4453GYV9Yy9uXkgQGoKZDJYVjvTtH2I X-Received: by 2002:a50:e70a:: with SMTP id a10mr14977889edn.38.1589840271702; Mon, 18 May 2020 15:17:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589840271; cv=none; d=google.com; s=arc-20160816; b=e/lgROw3zcFl0brP8QMgRuZmZm63l0d2tw3O4kbFUoUWWR5qAQuAq93GHl7v6gFiPz 1CSDNEI7qw46zT2lC2fwcyDI3GcsEnXYrMRkSsTVL55A87iEBkjTkOzF5tsr0ON0VsBQ G6osfrHj4M1Z/HLbTFqxkF4we0J5p1loyTA0qwQvR4Bd4VghCfegKyBc8r5GGQ/iOa4o WkP5sWWczCFa2vVNXKGEQr/6FjeZf+B+zskq3gOaY7lTAIFH9mjQ9Dm3Ow/N+iznfQoH P7ZXfJ+KVXIICfcc8jksRR5ZwMeDYDjcYDqdnu8TrRcc7wpp0O61g3wBEgOeJi9CKt48 60yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=llfoXoDbUl/zjbezMoNa+XpAXA1AlgWEQ8r/kkE3h8I=; b=N2wg66jOvw5UZs/B+OX9jLznQEPPgRpE9nJy2QGpXeCzEfwpp/0dl0yXb7+tHPCsV6 4gEiZ50p8YlXCAKSljVpFc8LFNJLgAyM0l4iBDpyEw0wxqz4xJkwnoItSVokQRMD4Auw TnqS/w8Buif9vri6rc2hWMO6zaFdMw+IC/h9hnAxbfQCMfLAcXRJ/BpKsHRK/gEUPLws lWUUakWau2A/sx0hi0TwendH3XS7lh1iLigvAnYeCYEaJEnamFFWs0IkyXpGfzRNqPNF oYaJ6dqBnKS2O7YwQjRmi1rN4UaNi0fyYocDuVuusLvuMnAKRf03uTge48kthyj89YAx xM7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fT61f7mz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w26si6400381edx.608.2020.05.18.15.17.15; Mon, 18 May 2020 15:17:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fT61f7mz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbgERWQu (ORCPT + 99 others); Mon, 18 May 2020 18:16:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:33480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbgERWQt (ORCPT ); Mon, 18 May 2020 18:16:49 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DE7920657; Mon, 18 May 2020 22:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589840209; bh=llfoXoDbUl/zjbezMoNa+XpAXA1AlgWEQ8r/kkE3h8I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fT61f7mzfm0m3Lue047kumZqLTm7/F4faZnDWN1uTHo4KF1ylu3cNS6l37Ux2pkVs WqISsIThqmyDfpUyAxKl1tPns4HyZ/yJj9XOGNkSN4K/ORRL3UYlicHtM6m16R5Bdr IYOw1z50Xlbq/Ho9/HGc4JqDO87NlzZd7zynX3SQ= Date: Mon, 18 May 2020 15:16:45 -0700 From: Jakub Kicinski To: Luis Chamberlain Cc: Johannes Berg , Steve deRosier , Ben Greear , jeyu@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, Takashi Iwai , schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, Kalle Valo , "David S. Miller" , Network Development , LKML , linux-wireless , ath10k@lists.infradead.org Subject: Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() Message-ID: <20200518151645.4693cf30@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200518212202.GR11244@42.do-not-panic.com> References: <20200518171801.GL11244@42.do-not-panic.com> <20200518190930.GO11244@42.do-not-panic.com> <20200518132828.553159d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <8d7a3bed242ac9d3ec55a4c97e008081230f1f6d.camel@sipsolutions.net> <20200518133521.6052042e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200518134643.685fcb0e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200518212202.GR11244@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 18 May 2020 21:22:02 +0000 Luis Chamberlain wrote: > Indeed my issue with devlink is that it did not seem generic enough for > all devices which use firmware and for which firmware can crash. Support > should not have to be "add devlink support" + "now use this new hook", > but rather a very lighweight devlink_crash(device) call we can sprinkly > with only the device as a functional requirement. We can provide a lightweight devlink_crash(device) which only generates the notification, without the need to register the health reporter or a devlink instance upfront. But then we loose the ability to control the recovery, count errors, etc. So I'd think that's not the direction we want to go in.