Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/4] brcmfmac: set net carrier on via test tool for AP
 mode
To:     Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        linux-wireless@vger.kernel.org
Cc:     brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <wright.feng@cypress.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Kurt Lee <kurt.lee@cypress.com>
References: <20200519110951.88998-1-chi-hsien.lin@cypress.com>
 <20200519110951.88998-4-chi-hsien.lin@cypress.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <77e05853-447c-76e2-9d71-a95397c36ff0@broadcom.com>
Date:   Tue, 19 May 2020 13:18:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200519110951.88998-4-chi-hsien.lin@cypress.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/19/2020 1:09 PM, Chi-Hsien Lin wrote:
> From: Kurt Lee <kurt.lee@cypress.com>
> 
> In manufacturing line, test tool may be used to enable SoftAP. Such
> SoftAP can't pass traffic because netif carrier is off by default. To
> allow such use case, let brcmfmac parse ioctl cmd, and then set iftype
> to ap mode and report netif_carrier_on to upper layer.
> 
> Signed-off-by: Kurt Lee <kurt.lee@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> ---
>   .../net/wireless/broadcom/brcm80211/brcmfmac/vendor.c    | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c
> index d07e7c7355d9..5edf5ac1167a 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c
> @@ -64,6 +64,15 @@ static int brcmf_cfg80211_vndr_cmds_dcmd_handler(struct wiphy *wiphy,
>                  *(char *)(dcmd_buf + len)  = '\0';
>          }
> 
> +       if (cmdhdr->cmd == BRCMF_C_SET_AP) {
> +               if (*(int *)(dcmd_buf) == 1) {
> +                       ifp->vif->wdev.iftype = NL80211_IFTYPE_AP;
> +                       brcmf_net_setcarrier(ifp, true);
> +               } else {
> +                       ifp->vif->wdev.iftype = NL80211_IFTYPE_STATION;
> +               }
> +       }
> +

I prefer to keep this code path as flat as possible so I prefer no 
monitoring of firmware commands issued by user-space. Maybe another 
approach would be to set the carrier on a firmware event?

Regards,
Arend