Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp3426448ybk; Tue, 19 May 2020 04:30:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznoN8kZw4iq8dDaqR5ib1uHiFXRatnWt7Conq/MCOrbJitimazTf18evDivHLxP+5AZqaY X-Received: by 2002:a17:906:d86:: with SMTP id m6mr214626eji.434.1589887830121; Tue, 19 May 2020 04:30:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589887830; cv=none; d=google.com; s=arc-20160816; b=YP7/OUCnRIlDzooKSld2ojm+mOanAPhhi/u3Ks00LBMNwQl/e9AQJDQFsmhnOTfxEa ov7PQc79pdDcIVy5dTktvgmyNj7Kk7wx5lCbfiqhdL8CxqaoumO9xw643tVnjRlArNmg OdzafaIBgkTqTXOJaQMExN1JvlQwf6skX0EG8Repc41BkG/8zl7K8hZWYbQACRy6V3iC sac5Oi3UlvQ9skTfmmE0ppoSuoxfEMevK8zjKa41BBgPeK6FdvCvs2v/e2uUv2gRxPAp 050vyxCt/lnc1l7RxezbI27PHGsuafpfybyt5NOBSfHlwM7uRMCjoMqtGtHx3mSWwAAH QNEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=m4bpJgcZVSxvKz7SUPl/kNfRjinxWx+k6EzLwOIoyaA=; b=PRYNB/blgFZqKH64TIuxJ3Q1rau9E9SxQps38g6v+MeCNdaomrf7bXuTUz6SpCnX7u 1Db0/VA/iil35y+5jx7zaG09QCc07bERpnQh8t9c6QiHH1s24QoSHclHPVwpblVbGCm3 OWBRLIYhq/xIc2qvNf4K10tT/Hw/rdEeQ0VVGl7+upMhXhN1eu4b8xcik5/eTwBcv9xl K2ZxPzR+Z0VmeGAofceAvPpxjC/fybldMEsURil/KLSIcwYTuGV3GhTBCwfh3odEkk8b mYfIFrAMDjW8EgUkl//1EuvYwcfkhAGMOYHONFe6lU0w7JdY4LY99ALSCgh3VvaMHxoX w0hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=WLVVVhN7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yc25si7927811ejb.373.2020.05.19.04.30.00; Tue, 19 May 2020 04:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=WLVVVhN7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbgESL3m (ORCPT + 99 others); Tue, 19 May 2020 07:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgESL3l (ORCPT ); Tue, 19 May 2020 07:29:41 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC683C08C5C0 for ; Tue, 19 May 2020 04:29:41 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id v63so6402672pfb.10 for ; Tue, 19 May 2020 04:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m4bpJgcZVSxvKz7SUPl/kNfRjinxWx+k6EzLwOIoyaA=; b=WLVVVhN7Wvglz2rw3NiojZp6shhRD0W5H4SHT1x7wtv7jZIGZnEx0Tjaa3KvH66Bys uD3ytw+gQIwktMRUhq+3sWoHK/3AaFJatuTIRqKIiuLVrAR/D7eIgWzs6yNkg5LayYw1 Cb7t1YTkvQGu70HTZ5OCGzUw5Y5qRPqfi+8D0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m4bpJgcZVSxvKz7SUPl/kNfRjinxWx+k6EzLwOIoyaA=; b=qGBQ9AckN/mKbrng/3mhc+fJrmKhh/v1RUPS/nNi9wpbc9yVFKdbBd2qAsIRO5ell3 82HtsX6WBZefRbipTY0lfMCIQ7khOwhCLvzXDHHsFjpwuNiit9ovV27ewB9sTPUXAl9K zjiPnnxcBBqdqoblrr2EW6oHaGR/WqErwy4aHApxFS7KaRDXxfdTsHhWOUiU6wKDMSrh RFfQa2MDSwpSL6zkv7zb+KTIHmK+brgx6ifgH+931lA5C5qJSw/Vc5PtuahGdWYJJP/1 /3EOqxY4SKlGPiKkmYnO9RuWyCBuF/6ej10+QHU5qz5KHIN9aPhRl5xiQQ+ZR88dAF76 eOsQ== X-Gm-Message-State: AOAM533DTg8x1jotNj/gMO4XXwt27+tBNWHr0nypIe7P0OGl0SgXo1Sz lXXaae0JXPVBODx4ngRume7/RA== X-Received: by 2002:a05:6a00:150e:: with SMTP id q14mr1478556pfu.325.1589887781334; Tue, 19 May 2020 04:29:41 -0700 (PDT) Received: from [10.230.34.187] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id t5sm9680904pgp.80.2020.05.19.04.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 04:29:40 -0700 (PDT) Subject: Re: [PATCH 4/4] brcmfmac: increase dcmd maximum buffer size To: Chi-Hsien Lin , linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Double Lo References: <20200519110951.88998-1-chi-hsien.lin@cypress.com> <20200519110951.88998-5-chi-hsien.lin@cypress.com> From: Arend Van Spriel Message-ID: <8d74b434-abdb-cbfd-ae21-5c083011375b@broadcom.com> Date: Tue, 19 May 2020 13:29:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200519110951.88998-5-chi-hsien.lin@cypress.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/19/2020 1:09 PM, Chi-Hsien Lin wrote: > From: Double Lo > > Increase dcmd maximum buffer size to match firmware configuration for > new chips. From the description I was expecting BRCMF_DCMD_MAXLEN to be increased but that is not the case. Please explain the need for the ROUND_UP_MARGIN. Is it always needed or just on some platforms? Regards, Arend