Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/4] brcmfmac: SoftAP creation and dcmd buffer size
 changes
To:     Kalle Valo <kvalo@codeaurora.org>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <wright.feng@cypress.com>
References: <20200519110951.88998-1-chi-hsien.lin@cypress.com>
 <87zha4do7h.fsf@kamboji.qca.qualcomm.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <09bf3506-2d25-d8a8-43eb-59a2e3d9a9ae@broadcom.com>
Date:   Tue, 19 May 2020 19:00:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <87zha4do7h.fsf@kamboji.qca.qualcomm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/19/2020 3:54 PM, Kalle Valo wrote:
> Chi-Hsien Lin <chi-hsien.lin@cypress.com> writes:
> 
>> Allow SoftAP creation via ioctl from test tool; also update dcmd buffer size
>> settings for new firmware. Also fix a sparse check error.
> 
> What ioctl is this exactly? Wireless drivers should be using nl80211,
> not any ioctl interface.

Hi Kalle,

The terminology is a bit off. This is vendor specific command 
interfacing directly with firmware and the content is opaque from driver 
perspective. However, a number of these commands have their nl80211 
equivalent. Especially regarding creation of AP interface I would simply 
go with creation through nl80211.

Regards,
Arend