Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [BUG?] b43: can't connect to WPA3 network (nohwcrypt=1)
To:     Rui Salvaterra <rsalvaterra@gmail.com>,
        b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
References: <CALjTZvbLOr5zAYyp75Cs6Zo8mWNUVq3ZRJu56G1iHdiihFejWQ@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <3483242e-c2ad-ec83-0c2c-ce952bc9b638@lwfinger.net>
Date:   Tue, 19 May 2020 15:30:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <CALjTZvbLOr5zAYyp75Cs6Zo8mWNUVq3ZRJu56G1iHdiihFejWQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/19/20 9:18 AM, Rui Salvaterra wrote:
> Hi, everyone!
> 
> I've been trying to connect to a WPA3 (personal, not enterprise)
> network but, as expected, the connection always fails with hardware
> encryption (most likely due to mandatory MFP, which the hardware won't
> do). What I didn't expect was to have the exact same problem when
> using software crypto. I've tried with other devices, and they work
> fine. One thing I noticed is this: for example, a Ralink RT2790
> device, on another machine, shows the following supported cyphers with
> hardware crypto…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
> 
> … and with software crypto…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
>          * CMAC (00-0f-ac:6)
>          * CMAC-256 (00-0f-ac:13)
>          * GMAC-128 (00-0f-ac:11)
>          * GMAC-256 (00-0f-ac:12)
> 
> … while b43 shows exactly the same in both modes…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
> 
> This is a BCM4318 device (PCI ID 14e4:4318), but I don't know if
> that's relevant.
> Is this behaviour expected?
> 
> Thanks in advance,
> Rui
> 

Rui,

 From other drivers, it appears that handling WPA3 might be as simple as setting 
MFP_CAPABLE in the hardware capabilities. Please try this patch:

diff --git a/drivers/net/wireless/broadcom/b43/main.c 
b/drivers/net/wireless/broadcom/b43/main.c
index 39da1a4c30ac..e944fe2e9ac7 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -4162,8 +4162,11 @@ static int b43_op_set_key(struct ieee80211_hw *hw, enum 
set_key_cmd cmd,
         int err;
         static const u8 bcast_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 
0xff };

-       if (modparam_nohwcrypt)
+       if (modparam_nohwcrypt) {
+               /* User disabled HW-crypto - enable MFP (WPA3) */
+               ieee80211_hw_set(hw, MFP_CAPABLE);
                 return -ENOSPC; /* User disabled HW-crypto */
+       }

         if ((vif->type == NL80211_IFTYPE_ADHOC ||
              vif->type == NL80211_IFTYPE_MESH_POINT) &&

I have no way of testing other than to compile.

Larry