Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [BUG?] b43: can't connect to WPA3 network (nohwcrypt=1)
To:     Rui Salvaterra <rsalvaterra@gmail.com>
Cc:     linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
References: <CALjTZvbLOr5zAYyp75Cs6Zo8mWNUVq3ZRJu56G1iHdiihFejWQ@mail.gmail.com>
 <3483242e-c2ad-ec83-0c2c-ce952bc9b638@lwfinger.net>
 <CALjTZvatxQ2BvUeZGcTFijBf1PiLizJuDdENxg2b=tPQL_NAzQ@mail.gmail.com>
 <CALjTZvYSJOx0xeMVkN6dHcGTdgW9O9NVbgXPKK4d6-31VX+0JQ@mail.gmail.com>
 <29f5e3de-a32c-6292-9197-19dcc57fa6a3@lwfinger.net>
 <CALjTZvaroTrgK9=W8uTwq9YcYayfuEU31BUc0qNYJr+08hevfg@mail.gmail.com>
 <CALjTZvaPi2FL-epk-Vd2wOLye2O0J8G5aZPsqzHXt2b7u=HyuQ@mail.gmail.com>
 <263e247c-3bf9-6d42-996b-bc513efe4b71@lwfinger.net>
 <CALjTZvauK0Hh+aoabcDX9kkQZ4zN2ZjPnB+aq7YrJ9+-4ihiAg@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <87fffd5d-242a-7195-c4cc-80260dbd53c5@lwfinger.net>
Date:   Wed, 20 May 2020 15:56:17 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <CALjTZvauK0Hh+aoabcDX9kkQZ4zN2ZjPnB+aq7YrJ9+-4ihiAg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/20/20 3:28 PM, Rui Salvaterra wrote:
> On Wed, 20 May 2020 at 21:08, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> I found this line in the b43 logs:
>> nl80211: NL80211_CMD_SET_PMKSA failed: -95 (Operation not supported)
>>
>> Could we also see the supplicant log for the RaLink driver that works?
> 
> Sure thing, here you go! This one's much shorter, since the connection
> was successful.

A quick difference - this one supports 3 additional ciphers:

vedder wpa_supplicant[376]: nl80211: Supported cipher 00-0f-ac:13
vedder wpa_supplicant[376]: nl80211: Supported cipher 00-0f-ac:11
vedder wpa_supplicant[376]: nl80211: Supported cipher 00-0f-ac:12

The one with :13 is for  BIP-CMAC-256, :11 is BIP-GMAC-128, and :12 is 
BIP-GMAC-256. I did not find a reference that says that these are needed for 
WPA3, but I am suspicious.

Thus far, I have not found where the driver tells nl80211 what should be supported.

Perhaps, we were calling ieee80211_hw_set() in the wrong place. Try

diff --git a/drivers/net/wireless/broadcom/b43/main.c 
b/drivers/net/wireless/broadcom/b43/main.c
index 39da1a4c30ac..211d6126734f 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -5569,7 +5569,10 @@ static struct b43_wl *b43_wireless_init(struct 
b43_bus_dev *dev)
         /* fill hw info */
         ieee80211_hw_set(hw, RX_INCLUDES_FCS);
         ieee80211_hw_set(hw, SIGNAL_DBM);
-
+       if (modparam_nohwcrypt) {
+               printk(KERN_INFO "b43: Setting MFP_CAPABLE\n");
+               ieee80211_hw_set(hw, MFP_CAPABLE);
+       }
         hw->wiphy->interface_modes =
                 BIT(NL80211_IFTYPE_AP) |
                 BIT(NL80211_IFTYPE_MESH_POINT) |

In addition, check that the printk message is seen in dmesg.

Larry