Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: MV5s2//wVBmgJnuFHaixoBfx7hQlPVfRjtGGcSVKUKUpEu0s6FT/2m6bCvb7IkCwGAFoYQo1cN
 Y5xjG/SK9PVg==
IronPort-SDR: MjuAy3kXc4oimvECVVyq3Nu7F9h4fpcJrS37Lk2uTU0LGdFGZAlui3/gPXnGWwT1cCKIPYxu+g
 u+hWmvbT7cUg==
From:   "Sang, Oliver" <oliver.sang@intel.com>
To:     Tony Chuang <yhchuang@realtek.com>,
        Kalle Valo <kvalo@codeaurora.org>, lkp <lkp@intel.com>
CC:     Andy Huang <tehuang@realtek.com>,
        "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [kbuild-all] Re: [linux-next:master 2957/8703]
 drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing
 braces around initializer
Thread-Topic: [kbuild-all] Re: [linux-next:master 2957/8703]
 drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing
 braces around initializer
Thread-Index: AQHCtP5KVt/tTPVQ+NI5/lIQdR2vYgIFCSEfAwhYSe6osQBbQIAAfGIAgAKZi0A=
Date:   Sat, 23 May 2020 11:31:53 +0000
Message-ID: <F09C421E5D2EBE40AFD7EEA977444DDC4D7B0779@SHSMSX103.ccr.corp.intel.com>
References: <202005141308.j8dUPd66%lkp@intel.com>
 <87blmljuqz.fsf@kamboji.qca.qualcomm.com>
 <08fd8d04c2d84d58ac751371cd1c4c1f@realtek.com>
 <F09C421E5D2EBE40AFD7EEA977444DDC4D77F535@SHSMSX103.ccr.corp.intel.com>
 <06f65d3990b94913a087a215e188cf1a@realtek.com>
In-Reply-To: <06f65d3990b94913a087a215e188cf1a@realtek.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> From: Tony Chuang <yhchuang@realtek.com>
> 
> >
> > > Kalle Valo <kvalo@codeaurora.org> writes:
> > >
> > > >
> > > > + linux-wireless
> > > >
> > > > kbuild test robot <lkp@intel.com> writes:
> > > >
> > > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > > master
> > > > > head:   e098d7762d602be640c53565ceca342f81e55ad2
> > > > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > > > rtw88:
> > > > > set power trim according to efuse PG values
> > > > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > > > reproduce:
> > > > >         git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > > >         # save the attached .config to linux build tree
> > > > >         make ARCH=i386
> > > > >
> > > > > If you fix the issue, kindly add following tag as appropriate
> > > > > Reported-by: kbuild test robot <lkp@intel.com>
> > > > >
> > > > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > > > >
> > > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > > > 'rtw8822c_power_trim':
> > > > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > > >> missing braces around initializer [-Wmissing-braces]
> > > > > s8 bb_gain[2][8] = {0};
> > > > > ^
> > > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > > > (near initialization for 'bb_gain[0]') [-Wmissing-braces]
> > > >
> > > > Tony, please check this and fix it. If it's a false warning please
> > > > let us know.
> > > >
> > >
> > > I tried to re-pro by:
> > >          git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > >          # save the attached .config to linux build tree
> > >          make ARCH=i386
> > >
> > > But cannot see it. And I checked the code, looks fine to me.
> > > It seems to be a false warning.
> >
> > Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
> >
> > From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning
> > should be only on old compilers.
> > If made below change, the warning will disappear.
> > @@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct
> > rtw_dev *rtwdev, s8 bb_gain[2][8])  static void
> > rtw8822c_power_trim(struct rtw_dev *rtwdev)  {
> >         u8 pg_pwr = 0xff, i, path, idx;
> > -       s8 bb_gain[2][8] = {0};
> > +       s8 bb_gain[2][8] = {};
> >         u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB,
> > PPG_2GH_TXAB};
> >
> > Similar fix could be seen, as an example, on
> > https://lkml.org/lkml/2017/9/12/159
> >
> 
> Oh, my gcc version is 5.5.0 20171010.
> OK, then I know it should be fixed for old gcc versions.
> Thanks!

Thank you

> 
> Yen-Hsuan