Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp309886ybs; Sun, 24 May 2020 06:09:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfzTFb6LKUutSHrcdF6aFYUDJ2c4hNMNXwHDg8ggDIp2//u7Q8MKEes5J3NnwewYwQhwRm X-Received: by 2002:a17:907:447e:: with SMTP id oo22mr14824761ejb.37.1590325792654; Sun, 24 May 2020 06:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590325792; cv=none; d=google.com; s=arc-20160816; b=Khqqw8NQmPoelu2JSXPRoQxBp2A8DiXwSvsWY72HlY/pO7JOBhdaBxc3NuLtY0gK1I xVJ6ekegoqrz3Rf3/YCTPpowRxavzwDFiWWj35rLHFmy/3ZOiQLXD8UdNgz8p2DmRHLg ses0bsUuvDvucVIx03u7Y5/bPU7Zo03UjTlXgq47rYulFPACPRt1f/pgk4mQzu1MsLgU J2rQy0sEZK/jP0GAvGIKAJ+YMrzfYyDxp8scr4MRGdVZHU0+TzZRS9yzt2tWr3ytZWgR /q0vW8DOLuStsLFevKnSlrk946BLLyGdCqxNJO8eApccNRT4TO/W0/tNXbb+g+G9hMsA 9lsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=8yLqNh6WgwZSpMDz0XbFH82COInG06+K0Z5aye5I8Uc=; b=KIJ56W2phZNbRD7B9Lj4edosEuBSji9oMtQvtApF0yQnIN4DTLIYrxzBIvodxk9hBE bgTgnAGEO+AxNowGVaZbqGoG5TcaHPlro08D4YMGnwNSp0tYBdYbKi8FWsuF3xTbuHYC YDLObQv6J+G3s23wsuzUW3wGoH7ZQvb/Fc96W+gJfdhlXotjzKHr4ULEzFOAemh9Ksxp boQJCTuJU9t8Zyv1q3jIeZYRiO6y6F4CIiWRGXbM+EtUc/r7/vX68C0dJAm+SCjzwdRH fEr05B0JM4jLk/R++adLs/5NWMM2r8B0Jk4zneO6US+Fp6/Fyl3JS9O8yLOKQDWqBc1w rhig== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=nqxMSAkK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me25si7561048ejb.481.2020.05.24.06.09.29; Sun, 24 May 2020 06:09:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=nqxMSAkK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbgEXNId (ORCPT + 99 others); Sun, 24 May 2020 09:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgEXNId (ORCPT ); Sun, 24 May 2020 09:08:33 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE019C061A0E for ; Sun, 24 May 2020 06:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8yLqNh6WgwZSpMDz0XbFH82COInG06+K0Z5aye5I8Uc=; b=nqxMSAkKuAvDGlKjpQqr7we6g9 ZBFUyT0n84nCvENhr1YFLyJlccxIfF6Gb0Nl6iFFmoyV62RgO/l1SJXVHZsI/3eRNs90YsRquRA7Q w39v1Ti0dEaUFjJDGQVT+pnMy4yyAt1fw3Z74CLxpa37/t9UVD9bgYU2zrBGwYYyh0MA=; Received: from p5b206c3b.dip0.t-ipconnect.de ([91.32.108.59] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jcqMh-00054q-1K; Sun, 24 May 2020 15:08:31 +0200 Subject: Re: [PATCH] mt76: fix BUG: spinlock bad magic in mt76_dma_init To: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com Cc: ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <54dc821bf69fe8e7ae017f221069a4f41ae37893.1590260648.git.sean.wang@mediatek.com> From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: Date: Sun, 24 May 2020 15:08:21 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <54dc821bf69fe8e7ae017f221069a4f41ae37893.1590260648.git.sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-24 12:14, sean.wang@mediatek.com wrote: > From: Sean Wang > > dma init should be done when dma have been allocated This fix seems incomplete to me. I've sent a replacement patch, please take a look. Thanks, - Felix