Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "kevlo@kevlo.org" <kevlo@kevlo.org>
Subject: RE: [PATCH] Revert "rtw88: no need to set registers for SDIO"
Thread-Topic: [PATCH] Revert "rtw88: no need to set registers for SDIO"
Thread-Index: AQHWLmsSvo/G/WdZGka1GdX2HzARfaiz6otjgAQuoEA=
Date:   Mon, 25 May 2020 02:20:49 +0000
Message-ID: <ffeca6916c00438482e15ab3a8bb2795@realtek.com>
References: <20200520055350.23328-1-yhchuang@realtek.com>
 <871rncb6xu.fsf@codeaurora.org>
In-Reply-To: <871rncb6xu.fsf@codeaurora.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> <yhchuang@realtek.com> writes:
> 
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > This reverts commit 07d0f5534935e2daf63a4e1012af13d68e089fed.
> >
> > For rtw88 driver, the SDIO is going to be supported, so there is
> > no need to remove the SDIO related power sequence settings. And
> > while the power sequence parser will pass in the mask of the HCI,
> > the SDIO part will not be used to set registers accordingly.
> >
> > Moreover, the power sequence table is released as a whole package,
> > so the next time if we are going to update, the SDIO settings will
> > be overwritten. So, revert this now.
> >
> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> Oops, I was supposed to drop that patch but somehow I did apply it
> anyway. Sorry about that, I'll apply this revert.
> 

It's fine :). Thanks.

Yan-Hsuan