Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [PATCH] ath10k: add SDIO firmware for QCA9377 WiFi
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <CA+5PVA5K0naJRhBvmDmArkBWQBCuA6p2yP+pYPMr3dZ47q53aQ@mail.gmail.com>
Date:   Mon, 25 May 2020 09:09:35 +0400
Cc:     Linux Firmware <linux-firmware@kernel.org>,
        Linux Wireless <linux-wireless@vger.kernel.org>,
        ath10k@lists.infradead.org, Kalle Valo <kvalo@codeaurora.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <37BB0344-C9EB-41F5-87E7-D66DA45A488E@gmail.com>
References: <20200524135933.1623-1-christianshewitt@gmail.com>
 <CA+5PVA5K0naJRhBvmDmArkBWQBCuA6p2yP+pYPMr3dZ47q53aQ@mail.gmail.com>
To:     Josh Boyer <jwboyer@kernel.org>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> On 24 May 2020, at 8:34 pm, Josh Boyer <jwboyer@kernel.org> wrote:
>=20
> On Sun, May 24, 2020 at 9:59 AM Christian Hewitt
> <christianshewitt@gmail.com> wrote:
>>=20
>> This commit adds the SDIO firmware for ath10k/QCA9377 cards. The file
>> is from the Boundary Devices repo [1] and has the same license as the
>> existing firmware-5.bin file. Support for QCA9377 WiFi was merged for
>> Linux 5.7 [2].
>>=20
>> [1] =
https://github.com/boundarydevices/qca-firmware/tree/bd-sdmac-ath10k
>> [2] =
https://github.com/torvalds/linux/commit/6e51b0e4913ca2c93059f73ca477ca30e=
a95b6a0
>=20
> That repo got it from Kalle's untested repo, and didn't carry over the
> Signed-off-by.  You didn't carry over the Signed-off-by from the repo
> you got it from.  3 levels of indirection to include a file with a
> giant notice from an untested sources is a bit too much for me to feel
> comfortable with.

Apologies Josh, I have been using my own repack of the Boundary Devices
repo and had completely forgotten Kalle=E2=80=99s repo existed and was =
the
original source of the file.

> Kalle, is there a reason you didn't send this upstream 3 years ago?

SDIO support is a relatively recent addition to the ath10k driver and
the commit message in this RFT [1] probably explains why his repo has
it described as untested.

I=E2=80=99m happy to submit v2 with corrected references or let Kalle =
handle
the submission, whichever is best or easiest is fine with me.

Christian

[1] https://patchwork.kernel.org/patch/11162833/=