Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200430063229.6182-1-rui.zhang@intel.com> <20200430063229.6182-2-rui.zhang@intel.com>
In-Reply-To: <20200430063229.6182-2-rui.zhang@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 25 May 2020 15:33:23 +0200
Message-ID: <CAJZ5v0j1Nehwq5eCVBo7StJ=vxBKpO454ywkVJmVRD=MQOVu=w@mail.gmail.com>
Subject: Re: [PATCH 1/6] iwlwifi: use thermal_zone_device_update() for
 temperature change
To:     Zhang Rui <rui.zhang@intel.com>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        "open list:NETWORKING DRIVERS (WIRELESS)" 
        <linux-wireless@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        andrzej.p@collabora.com,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        luca@coelho.fi
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 30, 2020 at 8:29 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> thermal_notify_framework() is an obsolete API, and iwlwifi is the only
> user of it.
> Convert iwlwifi driver to use thermal_zone_device_update() instead.

IMO it is rather hard to figure out what is going to change
functionally, from the driver's perspective, after this change.

In particular, is user space going to notice any change?  If so, then
what kind of change can it see?

> Note that, thermal_zone_device_update() is able to handle the crossed
> threshold by comparing the current temperature with every trip point, so
> ths_crossed variant in iwl_mvm_temp_notif() is probably not needed.
>
> It is still left there in this patch, in case the debug information is
> still needed.

Well, it should be possible to figure this out just from the code ...

> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> index 418e59b..6344b6b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> @@ -203,9 +203,8 @@ void iwl_mvm_temp_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb)
>
>         if (mvm->tz_device.tzone) {
>                 struct iwl_mvm_thermal_device *tz_dev = &mvm->tz_device;
> -
> -               thermal_notify_framework(tz_dev->tzone,
> -                                        tz_dev->fw_trips_index[ths_crossed]);
> +               thermal_zone_device_update(tz_dev->tzone,
> +                                          THERMAL_EVENT_UNSPECIFIED);
>         }
>  #endif /* CONFIG_THERMAL */
>  }
> --
> 2.7.4
>