Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/2] nl80211: FILS discovery/bcast probe resp support
To:     Aloka Dixit <alokad@codeaurora.org>, johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org, kbuild test robot <lkp@intel.com>
References: <20200526000913.30434-1-alokad@codeaurora.org>
 <20200526000913.30434-2-alokad@codeaurora.org>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <0c89ad68-67bf-7ade-7702-1695bb7274cb@broadcom.com>
Date:   Tue, 26 May 2020 10:18:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200526000913.30434-2-alokad@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/26/2020 2:09 AM, Aloka Dixit wrote:
> This patch adds new attribute, NL80211_ATTR_FD_BCASTPRESP_CFG
> to configure FILS discovery and broadcast probe response in 6GHz
> for in-band discovery.
> 
> Only one of the two is active at a time to reduce broadcast
> packets over the air.
> 
> Maximum packet interval can be 20 TUs.
> Packet interval set to 0 disables FILS discovery and broadcast
> probe response transmission.
> 
> Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
> Reported-by: kbuild test robot <lkp@intel.com>

huh? what is reported. Oh, guess it is the reason for having v2. Don't 
think this tag is useful for that. Only useful if v1 would have been 
applied and this patch would fix that.

> ---
> v2: Fixed warning.
> 
>   include/net/cfg80211.h       | 26 ++++++++++++++++
>   include/uapi/linux/nl80211.h | 27 +++++++++++++++++
>   net/wireless/nl80211.c       | 58 ++++++++++++++++++++++++++++++++++++
>   3 files changed, 111 insertions(+)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index a82fc59a1d82..e4bc03947005 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -957,6 +957,8 @@ struct cfg80211_crypto_settings {
>    * @assocresp_ies_len: length of assocresp_ies in octets
>    * @probe_resp_len: length of probe response template (@probe_resp)
>    * @probe_resp: probe response template (AP mode only)
> + * @bcast_presp: Broadcast probe response template (AP mode only)
> + * @fils_disc: FILS discovery template (AP mode only)
>    * @ftm_responder: enable FTM responder functionality; -1 for no change
>    *	(which also implies no change in LCI/civic location data)
>    * @lci: Measurement Report element content, starting with Measurement Token
> @@ -965,6 +967,8 @@ struct cfg80211_crypto_settings {
>    *	Token (measurement type 11)
>    * @lci_len: LCI data length
>    * @civicloc_len: Civic location data length
> + * @bcast_presp_len: Broadcast probe response template length
> + * @fils_disc_len: FILS discovery template length
>    */
>   struct cfg80211_beacon_data {
>   	const u8 *head, *tail;
> @@ -974,6 +978,8 @@ struct cfg80211_beacon_data {
>   	const u8 *probe_resp;
>   	const u8 *lci;
>   	const u8 *civicloc;
> +	const u8 *bcast_presp;
> +	const u8 *fils_disc;

This is not really beacon data, now is it?

Regards,
Arend