Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <256d488507006cff8b0a9bc80ab51ef0cee9ff7e.camel@sipsolutions.net>
Subject: Re: [PATCH v4 5/5] nl80211: S1G band and channel definitions
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Tue, 26 May 2020 15:01:23 +0200
In-Reply-To: <20200430172554.18383-6-thomas@adapt-ip.com> (sfid-20200430_192613_998673_DBD2473D)
References: <20200430172554.18383-1-thomas@adapt-ip.com>
         <20200430172554.18383-6-thomas@adapt-ip.com>
         (sfid-20200430_192613_998673_DBD2473D)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Thomas,

This looks mostly good (and I've applied the other 4 patches with some
fixups), but ...

> @@ -911,6 +931,15 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
>  	control_freq = chandef->chan->center_freq;
>  
>  	switch (chandef->width) {
> +	case NL80211_CHAN_WIDTH_1:
> +		width = 1;
> +		break;
> +	case NL80211_CHAN_WIDTH_2:
> +		width = 2;
> +		break;
> +	case NL80211_CHAN_WIDTH_4:
> +		width = 4;
> +		break;
>  	case NL80211_CHAN_WIDTH_5:

aren't you missing some bandwidths here? You'd fall through to a
WARN_ON(), which doesn't seem good?

johannes