Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp763763ybm; Wed, 27 May 2020 07:29:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbXXivzg3Vrwgm0Zvdis0wjKnxLRJGul+JjM0/1JxQVaiL3fbNepTahUkYzlmthwAHNFPY X-Received: by 2002:a50:d785:: with SMTP id w5mr23280490edi.212.1590589780554; Wed, 27 May 2020 07:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590589780; cv=none; d=google.com; s=arc-20160816; b=Mj5ydsT5eijInkHElDEOyG2f0XnXWSz0RkmcgFQXO5/aKtGOahReLVdtCPcE5gvkqR BSrC9NlDHzxCSj3+AiApeGTX0Ph6hyBD7y/Bx2e6C4wFRmPfhXAvY71RJTLzvXn26AUb PIUj2I9Yt266mrdBpD77LI6T9eHTliQWjZ4FeNrorjZ8PS8Qwq4AWwgSaT+t5ozzLuo0 dwFJMlPyo4s7vXg+K5YQXepp4uq8ugcKXlQ4UhlERtrG0rftZ/cjM6a/BnWOgFONt1Yd aEQpTH5N5Zreyko9BsAz856tqv59RDF3fNfroPWF2qHhg6wXbLaHORMLgjvI9LXgqqLS mc9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=gWPHAVUGXgQ18qKqJYZ1wK2ZN8OqM259PxJaPTpa6hw=; b=O8wqKrQE4/9BMELZfiOWMk6+FYFZ33qWyWBydUKj1n23y1wcaIu9SQ7Bal5eOvWjAq 6TydfIpj4xu8pEQ3yYS8X4izR4aoXfHhMNgLSmwFlgGp9L8rnLJWy+95JDHiuDZSwChz 9pC5/Sbl2jtQZjgTQPhSn4Mty3oxnpoJh6NdkZB5/IK+YBqbpzkPA/o2xDTKRlvKoHOf 03bGaljzcKZz6pg34/ZJgJ3MXOllfgwMopw/VJonwNZEMe2en+DJ4jtrkduxQmGVtdUx 1jP9ivIAne5HyNvFSY1Rzcp/laSen6YM/1bjTV5b1rX2Mzt9oYYEnf99n8I59NLrs0sq 36Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk10si1999655ejb.554.2020.05.27.07.29.16; Wed, 27 May 2020 07:29:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388809AbgE0O24 (ORCPT + 99 others); Wed, 27 May 2020 10:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388899AbgE0O24 (ORCPT ); Wed, 27 May 2020 10:28:56 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D82CC08C5C4 for ; Wed, 27 May 2020 07:28:56 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1jdx38-0049jw-Sr; Wed, 27 May 2020 16:28:54 +0200 Message-ID: Subject: Re: [PATCH v3 05/11] mac80211: fix memory overlap due to variable length param From: Johannes Berg To: Rajkumar Manoharan , kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Wed, 27 May 2020 16:28:53 +0200 In-Reply-To: <1589399105-25472-5-git-send-email-rmanohar@codeaurora.org> References: <1589399105-25472-1-git-send-email-rmanohar@codeaurora.org> <1589399105-25472-5-git-send-email-rmanohar@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2020-05-13 at 12:44 -0700, Rajkumar Manoharan wrote: > As of now HE operation element in bss_conf includes variable length > optional field followed by other HE variable. Though the optional > field never be used, actually it is referring to next member of the > bss_conf structure which is not correct. Fix it by declaring needed > HE operation fields within bss_conf itself. I had already applied this. johannes