Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] b43_legacy: Fix connection problem with WPA3
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        Rui Salvaterra <rsalvaterra@gmail.com>,
        Stable <stable@vger.kernel.org>
References: <20200526155909.5807-1-Larry.Finger@lwfinger.net>
 <20200526155909.5807-3-Larry.Finger@lwfinger.net>
 <87a71tv9g6.fsf@codeaurora.org>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <6375413e-88b2-effa-c972-63eb65a36d09@lwfinger.net>
Date:   Wed, 27 May 2020 09:57:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <87a71tv9g6.fsf@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/27/20 7:39 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
> 
>> Since the driver was first introduced into the kernel, it has only
>> handled the ciphers associated with WEP, WPA, and WPA2. It fails with
>> WPA3 even though mac80211 can handle those additional ciphers in software,
>> b43legacy did not report that it could handle them. By setting MFP_CAPABLE using
>> ieee80211_set_hw(), the problem is fixed.
>>
>> With this change, b43legacy will handle the ciohers it knows in hardare,
>> and let mac80211 handle the others in software. It is not necessary to
>> use the module parameter NOHWCRYPT to turn hardware encryption off.
>> Although this change essentially eliminates that module parameter,
>> I am choosing to keep it for cases where the hardware is broken,
>> and software encryption is required for all ciphers.
>>
>> This patch fixes a problem that has been in b43legacy since commit
>> 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx
>> devices").
>>
>> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org>
> 
> I'll do the same changes here as in patch 1.
> 

Yes, both are OK.

Larry