Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] nl80211: add control port tx status method
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
References: <20200527143653.3197-1-markus.theil@tu-ilmenau.de>
 <01ba6a6602e150b756fac8da1673cca34984c5d3.camel@sipsolutions.net>
From:   Markus Theil <markus.theil@tu-ilmenau.de>
Message-ID: <0f400886-9f09-3646-d068-fc7798db3ff6@tu-ilmenau.de>
Date:   Wed, 27 May 2020 18:03:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <01ba6a6602e150b756fac8da1673cca34984c5d3.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 5/27/20 4:47 PM, Johannes Berg wrote:
> On Wed, 2020-05-27 at 16:36 +0200, Markus Theil wrote:
>> This patch adds the actual code for returning the tx status of control
>> port frames sent over nl80211.
>>
>> NL80211_CMD_CONTROL_PORT_FRAME_TX_STATUS is a new command which is used
>> when returning the tx status. Its availability can be queried by checking
>> against NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_TX_STATUS.
>>
>> The ctrl port tx status over nl80211 path re-uses some code from the path
>> for advertising the tx status over socket control messages, when
>> SKBTX_WIFI_STATUS is set.
>>
>> The tx status can be used in a similar fashion as the mgmt tx status
>> already allows for. A cookie is included extended ack data of
>> NL80211_CMD_CONTROL_PORT_FRAME, which can be matched against the cookie
>> in NL80211_CMD_CONTROL_PORT_FRAME_TX_STATUS. The frame content is also
>> included, as for example hostapd currently uses it to match request and
>> reply.
> Looks good on a cursory review, but you forgot to set the feature flag?
Oh, I indeed forgot the flag.
> johannes
>