Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp305772ybm; Thu, 28 May 2020 03:16:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxm160d4BeWjU7g76s0ev0Le2WS6QcCmZfMn/NrpPuKyyrULuZokTrycbB5+EW+NdlL1abc X-Received: by 2002:a05:6402:a49:: with SMTP id bt9mr1564923edb.300.1590660979075; Thu, 28 May 2020 03:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590660979; cv=none; d=google.com; s=arc-20160816; b=vQ6YgmYFt85/D2MkJjeEK3sWnPOTLf5c/15rWmxAhfJHsw2DqH/HdW2wqmh/6RLg59 435ZZW1CS5bU5A2OrFL7BGZOZhPpDzaeKCXf2IuW9Ug6QKvhSdHux4u99J0d+Q6cQWSc E71gMoWWLXWS1VrTiX9JTvn4q7XTxxsRoNbBmhULetsBQcZRHDiHNyXkdPGMohrLfhK2 LTvHpphipHQJiq7sTKGQ0J0ys3W0hLT42wijM8lvj0IiGUSKOYwy0R0jr+buOQtHkHtJ sWk2ZWvQN+/ywjqVcKKb5bPgkz8MV1JPmWWqVa/Jsl89JJ0GFYQibPZBOqfxNgTbk6vl yGCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=CX+u123nVjVuRZW6zRvLQzHDlGFq6dyKso1AdFfB1VU=; b=aiCo2A1LXZRd/CEbYi7iFxsD1sgrDVk0RNa0ADj8S426In/2f7ErrI3Mww5d5A9klP 6SV6qdhI9TlA2UTVtzk6Mksv8Nt/PlQpEEL+nvtmuZxkPa5ccr8DhUkugHj4NsFdPzMS hlXL/DSJgvEK7zDC1/luvWYY0/WjK4y8lJP2RjBgNps0XaLwfB0/drgBOV5Vh4cWOKvD yRbVl0p7OYnsow1UjT3+hV2Y/EYcivX8JJYrWAonMURVjYdTkhp6gA8xuswl7gnsOCec t9Vn0TiH2HVTSWC0b99Ty7HOQjALORDTaG2uA3m/GxTlL2t2CsmvUVpdGUvwZs00CIt0 V9Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ylyyWluJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si3218215ejr.459.2020.05.28.03.15.48; Thu, 28 May 2020 03:16:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ylyyWluJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387751AbgE1KOp (ORCPT + 99 others); Thu, 28 May 2020 06:14:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387745AbgE1KOj (ORCPT ); Thu, 28 May 2020 06:14:39 -0400 Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99EBAC08C5C6 for ; Thu, 28 May 2020 03:14:38 -0700 (PDT) Received: by mail-vk1-xa42.google.com with SMTP id t23so1904243vkt.5 for ; Thu, 28 May 2020 03:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CX+u123nVjVuRZW6zRvLQzHDlGFq6dyKso1AdFfB1VU=; b=ylyyWluJV1udCPHKbUpBa9gzteEE9rpam5yb+9Qo5ZwIaIvYSKHGX3rwW8Qu1yRVbs s71Mhpbn4QTKCa9jPCBH3htvR2tWok5/1SRIeN1hxVVWT5gP564EBK2f09DGMHTsm88k E/1/Mm9s9RRLFrSj/olPzuvMcy35QUUaEA3viA62YTJSswW4ihcjUcj0j3CqjQk1t0Tw fOD6/+BDIpMYgME2I6zR07nY/c/eQBKM+cPSdHE+aeP51ba14fhxbL0ogMP3G7O7Ngvi MEJknki2sFvjerUF1dfNz5OXK1ad6hNSCiQ1ajt5pWLA71kvbSH7LxLetwkAl3aAifv+ ZtRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CX+u123nVjVuRZW6zRvLQzHDlGFq6dyKso1AdFfB1VU=; b=lAAOP+9kn6XCMSvnSJKOzDTyWI1PD8i+wftsY5KeP88nR3e86ypoPgfJWnPcCcTPiY Zwj8iet2cdhZobBbTwLKoTlkFXpiUZkk+bjebOwl1ienfERJAauup545F1g5I1pnbwJA LFslwXoQoUXA7UX5m7MJKyYRO52L/nhHOCEhK0g9cQkBSXum+lJFBwX48zxmMZUHJPi/ XCHtvD9wQ3Kgbpp9PXRsa5H6LEgAd7tn6u1/0TmF62hfxpvogyfjbRzire1fnUnLoi7s z0hYXcCiQxpqZaxN3bygPWtSED03wE/kmDS9k74ejhxJNu2YZOx13kC+hKFhoORnlp5J hUhw== X-Gm-Message-State: AOAM530cdolbau6oXyNuiwUkMHTD9qF7JvnmNl2dLELZPLfHtlwQpDTF lq+p2+DL90BzINe5iYyChud3xRtJu3Cpj30cuMaDpw== X-Received: by 2002:a1f:fc06:: with SMTP id a6mr1441822vki.101.1590660877077; Thu, 28 May 2020 03:14:37 -0700 (PDT) MIME-Version: 1.0 References: <20200522144412.19712-1-pali@kernel.org> In-Reply-To: From: Ulf Hansson Date: Thu, 28 May 2020 12:13:59 +0200 Message-ID: Subject: Re: [PATCH 00/11] mmc: sdio: Move SDIO IDs from drivers to common include file To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: "linux-mmc@vger.kernel.org" , Matthias Brugger , Mauro Carvalho Chehab , Kalle Valo , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Linux Kernel Mailing List , ath10k@lists.infradead.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list , libertas-dev@lists.infradead.org, linux-wireless , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 25 May 2020 at 09:15, Ulf Hansson wrote: > > On Fri, 22 May 2020 at 16:45, Pali Roh=C3=A1r wrote: > > > > Most SDIO IDs are defined in the common include file linux/mmc/sdio_ids= .h. > > But some drivers define IDs locally or do not use existing macros from = the > > common include file. > > > > This patch series fixes above inconsistency. It defines missing macro n= ames > > and moves all remaining SDIO IDs from drivers to the common include fil= e. > > Also some macro names are changed to follow existing naming conventions= . > > Thanks - a nice cleanup! > > I guess this is best queued via my mmc tree, unless bluetooth/wireless > maintainers think there are some problems with that. I will wait for > an ack from them before applying. It's getting late for v5.8, so I decided to queue this up as it's rather trivial changes. If anyone has an objection, please let me know. Thanks! Kind regards Uffe > > Kind regards > Uffe > > > > > Pali Roh=C3=A1r (11): > > mmc: sdio: Fix macro name for Marvell device with ID 0x9134 > > mmc: sdio: Change macro names for Marvell 8688 modules > > mmc: sdio: Move SDIO IDs from mwifiex driver to common include file > > mmc: sdio: Move SDIO IDs from btmrvl driver to common include file > > mmc: sdio: Move SDIO IDs from btmtksdio driver to common include file > > mmc: sdio: Move SDIO IDs from smssdio driver to common include file > > mmc: sdio: Move SDIO IDs from ath6kl driver to common include file > > mmc: sdio: Move SDIO IDs from ath10k driver to common include file > > mmc: sdio: Move SDIO IDs from b43-sdio driver to common include file > > mmc: sdio: Fix Cypress SDIO IDs macros in common include file > > mmc: sdio: Sort all SDIO IDs in common include file > > > > drivers/bluetooth/btmrvl_sdio.c | 18 ++-- > > drivers/bluetooth/btmtksdio.c | 4 +- > > drivers/media/mmc/siano/smssdio.c | 10 +- > > drivers/mmc/core/quirks.h | 2 +- > > drivers/net/wireless/ath/ath10k/sdio.c | 25 ++--- > > drivers/net/wireless/ath/ath10k/sdio.h | 8 -- > > drivers/net/wireless/ath/ath6kl/hif.h | 6 -- > > drivers/net/wireless/ath/ath6kl/sdio.c | 17 ++-- > > drivers/net/wireless/broadcom/b43/sdio.c | 4 +- > > .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 +- > > .../broadcom/brcm80211/brcmfmac/sdio.c | 4 +- > > .../net/wireless/marvell/libertas/if_sdio.c | 2 +- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 38 ++------ > > include/linux/mmc/sdio_ids.h | 94 ++++++++++++++----- > > 14 files changed, 120 insertions(+), 118 deletions(-) > > > > -- > > 2.20.1 > >