Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] cfg80211: adapt to new channelization of the 6GHz band
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
        Jouni Malinen <j@w1.fi>
References: <1590053692-237138-1-git-send-email-arend.vanspriel@broadcom.com>
 <cbc3a214-db0d-18d4-b878-80277c210956@broadcom.com>
 <8dc9a15d50a28aea21cf452b5abe8487a542ae8e.camel@sipsolutions.net>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <5732ba1c-ee47-dcfd-292a-fe2ae7ab0b6d@broadcom.com>
Date:   Fri, 29 May 2020 10:40:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <8dc9a15d50a28aea21cf452b5abe8487a542ae8e.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/29/2020 10:19 AM, Johannes Berg wrote:
> On Fri, 2020-05-29 at 10:16 +0200, Arend Van Spriel wrote:
>> The 6GHz band does not have regulatory approval yet, but things are
>> moving forward. However, that has led to a change in the channelization
>> of the 6GHz band which has been accepted in the 11ax specification.
>>
>>    	case NL80211_BAND_6GHZ:
>> -		/* see 802.11ax D4.1 27.3.22.2 */
>> +		/* see 802.11ax D6.1 27.3.23.2 */
>> +		if (chan == 2)
>> +			return MHZ_TO_KHZ(5935);
> 
> I think Jouni said this was operating class 136?
> 
>> +	/* 6GHz, channels 1..233 */
>> +	if (freq >= 5935 && freq <= 7115) {
>> +		switch (chandef->width) {
>> +		case NL80211_CHAN_WIDTH_20:
>> +			*op_class = 131;
>> +			break;
>> +		case NL80211_CHAN_WIDTH_40:
>> +			*op_class = 132;
>> +			break;
>> +		case NL80211_CHAN_WIDTH_80:
>> +			*op_class = 133;
>> +			break;
>> +		case NL80211_CHAN_WIDTH_160:
>> +			*op_class = 134;
>> +			break;
>> +		case NL80211_CHAN_WIDTH_80P80:
>> +			*op_class = 135;
>> +			break;
>> +		case NL80211_CHAN_WIDTH_5:
>> +		case NL80211_CHAN_WIDTH_10:
>> +		case NL80211_CHAN_WIDTH_20_NOHT:
>> +		default:
>> +			return false;
>> +		}
> 
> If so, isn't that missing here?

At least should indeed take it into account here. However I can not get 
my hands on the 6.1 spec (yet). I have the document with editor 
instructions and operating class for channel 2 is marked as <ANA> in 
table Annex E-4. 136 would be the logical value, but without the 6.1 
spec I am not sure. I will resend the patch.

Regards,
Arend