Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp729095ybm; Fri, 29 May 2020 10:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTPCV3ZQsATeDalZEve+VPE8xC3ESFLsVOp18VA30Biw8tqb8pzyXf0AzQDYLDqQlWZ9do X-Received: by 2002:a17:906:c01:: with SMTP id s1mr8854678ejf.370.1590774183341; Fri, 29 May 2020 10:43:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590774183; cv=none; d=google.com; s=arc-20160816; b=u0KlZORp6/EN8L2QB0qAe854dlT8WA4NJSANCIqHcR665JnOSWlK/TxOCPn3ZwK54j sQTgMTExI6Jd0xx3Rbs87HZKT1mbQTp/nh7DLYSZbjqPAPMktAtFphf83W+1kEEL0NGj EBLxoQZXcNTB9RkMt2rpUD4ZVg56QO4LEf3xnZboLyUr2E7icdTT4+K6h0T4KURqAoYg aybipzWd+6dbqag+Agi6uLr+AdMd6J/j7ZMOqE5V4tZQS+Z35YLsymn527cZbpa88IP+ W9dThvzxxKCa+hyoa4IDwImxJrKCYmz4ubgp+R+QEhHsqqPMSUT5igv4Ah1Mm/4E+ag8 G+VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=UXXBbJcWAQNE1ZNglKbbAUXpi4LDBG4fZpZm8mlyhPk=; b=nCpOJoJOum4ucSd+dX9k6Gc0lSjk65lH08hR+T2OuC8xbFdONf4x39NvtxUYd+e/fY VhxteyGWhhCPGqc6NjorqD9nUBbCw/8YJj2lKEy+QO6cOZYuMXWa+wx5ZZcybIBbc3Ke a0fo1LjJY0+TyLCmMaaqzoS5qONWXsI/XeHXZrvUhwYwyMcioiMXu9bWJ/6z1GNL+cMt K4jbTebiuT3qcUmIip0/7FZut19KsleWhcq7cQGkVjeqj5zDu+ObMkmiPDl4tZM0aFnk DrdXdRrBRFfzk1DuwNO4UucSmROvu7/9oTqeG/jxTxYjg9QrXYWBhTaclw0OFNoC/gre CtxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=v05PjHC6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si6034798edq.603.2020.05.29.10.42.40; Fri, 29 May 2020 10:43:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=v05PjHC6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbgE2Rks (ORCPT + 99 others); Fri, 29 May 2020 13:40:48 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:50310 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbgE2Rks (ORCPT ); Fri, 29 May 2020 13:40:48 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590774047; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=UXXBbJcWAQNE1ZNglKbbAUXpi4LDBG4fZpZm8mlyhPk=; b=v05PjHC6gwI5cZDtY9w98OAbawwPs6de1UH8brXt90bIcOc6eiOY+m47GcO4/9qaNX6hpLlj XEaLE992+vndwOYKYfN2i8lMPBfBRDKmA6zawq6avzbgH1Y0EAbaQEaSVh0nRSTp0vKpM8y+ kt2qHppRKIQqbyMuqM4w6k1QkdY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5ed14917b65440fdba15c1f4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 29 May 2020 17:40:39 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6EC21C433C6; Fri, 29 May 2020 17:40:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C6F27C433C9; Fri, 29 May 2020 17:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C6F27C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] airo: Fix read overflows sending packets From: Kalle Valo In-Reply-To: <20200527184830.GA1164846@mwanda> References: <20200527184830.GA1164846@mwanda> To: Dan Carpenter Cc: Hu Jiahui , Eric Dumazet , security@kernel.org, linux-wireless@vger.kernel.org, Jakub Kicinski User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200529174038.6EC21C433C6@smtp.codeaurora.org> Date: Fri, 29 May 2020 17:40:38 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The problem is that we always copy a minimum of ETH_ZLEN (60) bytes from > skb->data even when skb->len is less than ETH_ZLEN so it leads to a read > overflow. > > The fix is to pad skb->data to at least ETH_ZLEN bytes. > > Cc: > Reported-by: Hu Jiahui > Signed-off-by: Dan Carpenter > Reviewed-by: Eric Dumazet Patch applied to wireless-drivers-next.git, thanks. 11e7a91994c2 airo: Fix read overflows sending packets -- https://patchwork.kernel.org/patch/11573765/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches