Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 5/5] nl80211: S1G band and channel definitions
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
References: <20200430172554.18383-1-thomas@adapt-ip.com>
 <20200430172554.18383-6-thomas@adapt-ip.com>
 <256d488507006cff8b0a9bc80ab51ef0cee9ff7e.camel@sipsolutions.net>
From:   Thomas Pedersen <thomas@adapt-ip.com>
Message-ID: <3ef2eb73-22e3-3324-74be-514d2d9032e9@adapt-ip.com>
Date:   Mon, 1 Jun 2020 10:16:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <256d488507006cff8b0a9bc80ab51ef0cee9ff7e.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 5/26/20 6:01 AM, Johannes Berg wrote:
> Hi Thomas,
> 
> This looks mostly good (and I've applied the other 4 patches with some
> fixups), but ...
> 
>> @@ -911,6 +931,15 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy,
>>  	control_freq = chandef->chan->center_freq;
>>  
>>  	switch (chandef->width) {
>> +	case NL80211_CHAN_WIDTH_1:
>> +		width = 1;
>> +		break;
>> +	case NL80211_CHAN_WIDTH_2:
>> +		width = 2;
>> +		break;
>> +	case NL80211_CHAN_WIDTH_4:
>> +		width = 4;
>> +		break;
>>  	case NL80211_CHAN_WIDTH_5:
> 
> aren't you missing some bandwidths here? You'd fall through to a
> WARN_ON(), which doesn't seem good?

Yep. Looks like hwsim tests needs a test for larger bandwidths.

-- 
thomas