Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wright Feng <wright.feng@cypress.com>
To:     linux-wireless@vger.kernel.org
Cc:     wright.feng@cypress.com, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@codeaurora.org>, chi-hsien.lin@cypress.com
Subject: [PATCH v2 2/5] brcmfmac: fix invalid permanent MAC address in wiphy
Date:   Thu,  4 Jun 2020 02:18:32 -0500
Message-Id: <20200604071835.3842-3-wright.feng@cypress.com>
In-Reply-To: <20200604071835.3842-1-wright.feng@cypress.com>
References: <20200604071835.3842-1-wright.feng@cypress.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from iot-wlan-dev-u02.aus.cypress.com (12.110.209.245) by MN2PR01CA0049.prod.exchangelabs.com (2603:10b6:208:23f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3066.18 via Frontend Transport; Thu, 4 Jun 2020 07:18:51 +0000
X-Mailer: git-send-email 2.25.0
X-Originating-IP: [12.110.209.245]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 2de5c2da-33d9-4183-f62d-08d80857889e
X-MS-TrafficTypeDiagnostic: DM6PR06MB5146:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR06MB51466879CE02373B692863F7FB890@DM6PR06MB5146.namprd06.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1775;
X-Forefront-PRVS: 04244E0DC5
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1sSQzzfYXLsSw5D/nP+vN0CP9RGiBfqgFgTKDanPza3SoxZAHChPixvZ2hMhh+7Tu7ydZKhzfQoZOxuJYE5l042mUrkC0/jVLYY8UFBtOtOtfecYK3s8QyuHT5YhYv77SsoGOoMXT5VQY0pZpkKfwjj84hDO63lYzdtKovvzHyBrfPJpOoVVWL96w9hlxlJVkx8bh1v6YZ8d0VhRH6Zb7aei/W0Wndfimq9Zvf0ZUlEFPFGdZR2VybIebt1vx1w97wE94LVcpPM1WnGnLmh1VjKUA7JjyPi8709w08csLex3w3XncShqQJaCcDAknr20
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR06MB4748.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(39860400002)(346002)(396003)(366004)(136003)(316002)(54906003)(6666004)(26005)(16526019)(186003)(2616005)(52116002)(36756003)(956004)(7696005)(44832011)(1076003)(8936002)(8676002)(83380400001)(107886003)(6916009)(5660300002)(2906002)(4326008)(86362001)(6486002)(478600001)(66476007)(66946007)(66556008);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: Zs2/gu6BhKNZ66EIE/Q0S2P9Df+dfxRLGnCHGcquh6C9599U0xnnaDOhiZd8Bf6fGcu1qEa+qdI3ZFljGNkD/g2+BoRTr11SP/oy/9Lu3WjF8kloZecIP6AmbNpJ2A4KTtcjYiAeLYb58GcYbtQHF55Yb20xUkKQEvsQhLOYjoMdSUkAWYwcCPiepZd3kiRxDTA3YCRJ8PVs9OUr7AD7MCEjlRoI2m/hexp6c99yWw23ARtFGAWQ1Up+sCuhXWIoZ8h8xxS7kyUWGdISTc1vrxmVKiQ7eJifX7au1/PkYd61T4lNBjrGYfDlmizMbIQ9mH4xTrxp1GN2vl5XA1QnvH/PxDyKTbGhikSh0HbCH6OCshc0gpT0PSIt5tQK4C9VLYB5my8Vrvs1OSCpGa3hpdbwz+8L/iGoSdo7s377Cv/QamEPhsXertdMQdOumWbIHjCfzm25ihZCS9w5LdIw5cY263zkg6hinwwIPtUW0Jv7gqOdpRoH8VICdbSM/3ud
X-OriginatorOrg: cypress.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2de5c2da-33d9-4183-f62d-08d80857889e
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2020 07:18:52.4039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xo4jZm3q215782NyS4tDy5e6p5EUdLvJmhkLrxKtsIGxPmDsY8gtBQgVNnDwBamoH7AYKziKBJAHjg/XhBdwZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB5146
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

When host driver retrieves mac addresses from dongle, driver copies memory
from drvr->mac to perm_addr. But at the moment, drvr->mac is all zero
array which causes permanent MAC address in wiphy is all zero as well.
To fix this, we set drvr->mac before setting perm_addr.

Signed-off-by: Wright Feng <wright.feng@cypress.com>
---
v2:
 - Correct the typo in commit subject

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
index dec25e415619..e3758bd86acf 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
@@ -209,8 +209,8 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp)
 		bphy_err(drvr, "Retrieving cur_etheraddr failed, %d\n", err);
 		goto done;
 	}
-	memcpy(ifp->drvr->wiphy->perm_addr, ifp->drvr->mac, ETH_ALEN);
 	memcpy(ifp->drvr->mac, ifp->mac_addr, sizeof(ifp->drvr->mac));
+	memcpy(ifp->drvr->wiphy->perm_addr, ifp->drvr->mac, ETH_ALEN);
 
 	bus = ifp->drvr->bus_if;
 	ri = &ifp->drvr->revinfo;
-- 
2.25.0