Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2031070ybg; Fri, 5 Jun 2020 03:55:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOmKpUuMGpJVpPt670naEMTX7+WrYusug/XzGpM+AMxjoeQIi+sXklqVDNBLL6tZTImbKZ X-Received: by 2002:a17:906:a387:: with SMTP id k7mr8686385ejz.408.1591354556419; Fri, 05 Jun 2020 03:55:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591354556; cv=none; d=google.com; s=arc-20160816; b=GIbIwaBnPH4yn+DfpVHLx1CQkb1ZXoypBxlafE19NryW/Sn2EA10/NEVeBeluHrn0t PVvXiD/70YBpumVo2QNcqPHCWtoTo2tvLEhEBOyCI3ZP9+3Dz7B32NT2sIZJ5OvfPphU +vDoc0txIt+O8/jG73vSnDEIMVCW2qnP0YNi7ohKrg48L3LW7EDGFdsXg0FNui52YbJl t719Elh++ix1ijrFbOC0oc2E7XJapuotdWzjzVy6XwnQ2d/XR5OnkySAfBBJbDRJedfJ 5RKDFuXXRCFwJ2OfrSZMejywsKLbl/wSpKMYpm6xeUTmbEs+jmrxmhp2q0w4I6bhOxJC bwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=SnJluwkXF+QouVDnsSo2BU3XDWLLvgIw5nZbcolGEUo=; b=TWBjMDVi/e7CM1REYNRNvylTYVGHLpB95D2NnqdFXXa4aZZu/l5RC/GCfaduSX2uY1 0e9dOmEPTbAFxlhox/CHpAlYj/aCG8NXLz8LKN1NkdMggAWpSFuM28fmJuTfGuL6HrPc Sc/oARO5nmuPYY+1vZRn0YLet53G0mAQkP+FRYDuofGz4n8/988Qe0k4col5+1GHtBSP iqqt5ZiP5yGmVMOXCNuGnZe6fpXKLmyDgK2W4peHNiy9v4FLD6l6ZpOeEIhWTpIhQLpA LQnNneg8WXHVbHPyKNy1tfOjYryCpudJKmPoil5flITM7WkyNtgMjIW2xEssWpu3CIno SqUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s17si3789019edi.175.2020.06.05.03.55.25; Fri, 05 Jun 2020 03:55:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbgFEKxa (ORCPT + 99 others); Fri, 5 Jun 2020 06:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbgFEKxa (ORCPT ); Fri, 5 Jun 2020 06:53:30 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06475C08C5C2 for ; Fri, 5 Jun 2020 03:53:30 -0700 (PDT) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1jh9ya-0002Rg-5X; Fri, 05 Jun 2020 12:53:28 +0200 Date: Fri, 5 Jun 2020 12:53:28 +0200 From: Sebastian Andrzej Siewior To: yhchuang@realtek.com Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, tehuang@realtek.com Subject: Re: [PATCH v2 1/5] rtw88: 8821c: add cck pd settings Message-ID: <20200605105328.2anlgi3tkclknj4y@linutronix.de> References: <20200603094218.19942-1-yhchuang@realtek.com> <20200603094218.19942-2-yhchuang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200603094218.19942-2-yhchuang@realtek.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-06-03 17:42:14 [+0800], yhchuang@realtek.com wrote: > @@ -596,6 +597,29 @@ static void rtw8821c_phy_calibration(struct rtw_dev *rtwdev) > rtw8821c_do_iqk(rtwdev); > } > > +static void rtw8821c_phy_cck_pd_set(struct rtw_dev *rtwdev, u8 new_lvl) > +{ > + struct rtw_dm_info *dm_info = &rtwdev->dm_info; > + u8 pd[CCK_PD_LV_MAX] = {3, 7, 13, 13, 13}; > + > + if (dm_info->min_rssi > 60) { > + new_lvl = 4; > + pd[4] = 0x1d; replace 4 with CCK_PD_LV4 ? > + goto set_cck_pd; > + } Sebastian