Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp2278805ybg; Fri, 5 Jun 2020 09:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl1rdCWf0jGK/IzuxIBWmPi2esVvSvk4GpqaQvZOqcNQff5KFluCccUz1wR3xPaZwZ7t2Q X-Received: by 2002:aa7:c403:: with SMTP id j3mr10278905edq.294.1591375850589; Fri, 05 Jun 2020 09:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591375850; cv=none; d=google.com; s=arc-20160816; b=0blxQrveaBMU3/1Gc+b4bDGpYWh0W+fZE4meH/x/99oTCCGgaSWg4bSlGqvWyTm25e v7+VpXDGN3lNEKhuXY1syH3GbLzrLPItLY4EGbxS/lp/6a2upPkteKWM/pSoohU7ZEid g5i5V0kGlVSaqOOoaByDEXhkMhL07Tj8+f+wKpBnG+eTuN3KP7YZpfFt/0zvyJHgwcAM rImzEYCb/QOJ6b9D1Wu6ICwdHn7G56xR8pUIpppFwVi4dK/59r7BUETgqe7WBvA6uO0c uqGWySF2aTqK8cPMln3vuw7eXIFpQTWGNbhOSd5NQuU1FBp7T2jQ9cTEJznmg5RR5lrR aMTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=+lG+keetwhey9x40EJaUhszexlw7ioKHYssfiTTG8Bw=; b=oWZRhvFmgjKCtSCw6btAAA/5KFldBhvsoIR+rHdJ5u136o+ezCkQsnkQD/vOkzAejl NvXtJ7ZZcQcsPGghRy1BlnEVcAUEpTLmv/gfkSPGaMourjQmWgFdzEys6HL5QPOSJZm3 psZKTeY8PXGBOfs/VycGW+++m36gKk0QTDjtTNCLDMR0ZcC2Gw1fk8QC2CSAd0DXOPaJ tmOL4qXhy6AmT+KLdR8PTwvaEURIcHo/9Nb7Bg5GjRxBPq/VTNcGbthw0UmTgb26DtNJ PfZpBgmD7GWr5TERn2RQyVOotFeXdl38KnMBgC3noXA0Fwr0+NoLxHzu0KNeIcFx4j0X Ig1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z10si3717719ejb.517.2020.06.05.09.50.13; Fri, 05 Jun 2020 09:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgFEQtm (ORCPT + 99 others); Fri, 5 Jun 2020 12:49:42 -0400 Received: from muru.com ([72.249.23.125]:57048 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgFEQtm (ORCPT ); Fri, 5 Jun 2020 12:49:42 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E034980F5; Fri, 5 Jun 2020 16:50:31 +0000 (UTC) Date: Fri, 5 Jun 2020 09:49:38 -0700 From: Tony Lindgren To: Navid Emamdoost Cc: Kalle Valo , "David S. Miller" , Johannes Berg , Thomas Gleixner , Greg Kroah-Hartman , Hari Nagalla , "Jason A. Donenfeld" , Emmanuel Grumbach , Maital Hahn , Fuqian Huang , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu, smccaman@umn.edu Subject: Re: [PATCH] wlcore: mesh: handle failure case of pm_runtime_get_sync Message-ID: <20200605164938.GH37466@atomide.com> References: <20200605032733.49846-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200605032733.49846-1-navid.emamdoost@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org * Navid Emamdoost [200605 03:28]: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. Looks like we have a similar patch already in Linux next, care to check? Regards, Tony