Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp4306054ybg; Mon, 8 Jun 2020 04:39:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIfk5Jcy8MJtLCgiPPG+mNRPjWNQktA4CxL+VMf/NztbbLHTZPp0Jy6WinhJdATPj+EZt8 X-Received: by 2002:a17:906:da05:: with SMTP id fi5mr21008118ejb.95.1591616377294; Mon, 08 Jun 2020 04:39:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591616377; cv=none; d=google.com; s=arc-20160816; b=h6QC4Z345LH2D9WeQpG79acxm2NsdFqN9/KcrEr36aCsWhzsSxkNDvxy1VPw43oQoo n/lH25TxZa5u/Awy9Jp24nlkM2SlvC5fpvN5pMcMwlaYsufJPX7Asip0r0KVQ2LzR0ef 9JiCNSSH/Q6Ck3ghOTCoV785cmFrm6gYv6pjN3D/6EaswTFZgcd4mO5yj5PrvnI4qJiy wF68G30EnaAAmNmM+8Tk8b2HLDR8EbNe7OzuytF3TDxRhTWnzfdiSf1zWDD8/256cr46 RyFxoc2tro9MhjhEqNx5PA2xiefkA6z3XqOapE0NiOyA4XC/UnMi7UKeCns8J9uxx2QI IrPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=UlNfDGogKCJ2Hte3WfYZUyoDNhoWUwvyIBaQzivZeyg=; b=cBKKN9MWKxGOGgeQfHYj6rw6Gn+dqoXpJCbFWqBAitVasgNS3oDbpL+lrGGj3iWtwh tx12/vUhbT1uNsphFXrHpGIct4WLmfRj3PRyuleTC+fDqhFqAA+kuOutA6krtben+EyJ o0A3SVQvbBvvn8GxeObzw2suAHrPky0lRDdE6Dmuas8wxeFhz6b9HpkxnAxzmUgzI8y5 xy9vbJuSAlnYdJYnnB1lijM8Dy4Qb/lII+VGsS9dPW+PAQQI+WhodqljxIE2zUhAFpwI xkgsPKnLa6Q08HZDGZ7t9gtguhBi8DV5T10kooxXZdAa7LUUF7DwHZtjF8kjO+wwcSQ+ kZbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=pY9K81cr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si8577216eji.128.2020.06.08.04.39.13; Mon, 08 Jun 2020 04:39:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=pY9K81cr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729620AbgFHLi7 (ORCPT + 99 others); Mon, 8 Jun 2020 07:38:59 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:17218 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729584AbgFHLi4 (ORCPT ); Mon, 8 Jun 2020 07:38:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591616335; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=UlNfDGogKCJ2Hte3WfYZUyoDNhoWUwvyIBaQzivZeyg=; b=pY9K81crIXaKvri2Dj/J2kiyKCzV1V1H5KtIXdNwrdBqYhFzJnWPWqQIPf+vQVPH2FHeK/PJ NETBQ99XZWOzDSbmIMfhN8gf8ujJ6QQf4H4XzDK5OuTwlW9bdE3Pnz39IVzbOgtNQjSyHdR3 fBpP5KAsmPbS7iyFAHienypTFe0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n12.prod.us-east-1.postgun.com with SMTP id 5ede234a8bec5077688023cd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Jun 2020 11:38:50 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B8DF7C433A1; Mon, 8 Jun 2020 11:38:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 920A6C433CA; Mon, 8 Jun 2020 11:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 920A6C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Evan Green Cc: Govind Singh , kuabhs@google.com.org, sujitka@chromium.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Michal Kazior , Jakub Kicinski , "David S. Miller" Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths References: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> Date: Mon, 08 Jun 2020 14:38:43 +0300 In-Reply-To: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> (Evan Green's message of "Thu, 4 Jun 2020 10:59:11 -0700") Message-ID: <87v9k1iy7w.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Evan Green writes: > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > is held. Acquire the lock in a couple of error paths when calling that > function to ensure this condition is met. > > Fixes: 6421969f248fd ("ath10k: refactor tx pending management") > Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64 > descriptor") Fixes tag should be in one line, I fixed that in the pending branch. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches