Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp1192557ybg; Thu, 11 Jun 2020 03:30:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3Emp3CXJAhkMZVSUsjgilh7p5rLfsjA6cWPm2JW5HJUi/QI3zIXG0w5AYCX4B6Wp0+EqD X-Received: by 2002:a17:906:e115:: with SMTP id gj21mr7367176ejb.528.1591871406856; Thu, 11 Jun 2020 03:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591871406; cv=none; d=google.com; s=arc-20160816; b=ejwK3WoKqqjgqZbdWYJnSCktH+SWLUnY2b3MKA9Ox0vr6PIbKPWuEHb1QOOHoe6Su5 p6tg/IKSQZVewYZb9r7vlH7KkcEDPjX4Cm2mBTMFYd8OJnxG56kE5WtMvw1db10c48XP HwV83oqRYiF8i2WltVFykSnHnvoc7AowNIbe+1hkiFNUiyUhty1kyemdJx/83vDfYKeP DVFZKW5zYTbtU8abeW6sPG+cp9AlZhG3Px49oNm9cOJ3kiTZ2wj2p5VcWqjq2bdtYEds iaOK3nLvmAxN4lROuBtbz6nEWMiihdKJh5U03XPeokg7MogLygYfjMFWZhxesDzE/PlD rVPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=fACBsTVb+UiZn0O/01yCgDIDH9BcfLKltELGTON6YQk=; b=QUwNmnrS9/r9A7yv9f6fthMJ3TIo8cvJahPjpfY2SBFW7Yncyr0LlB4shKlyrJuWBC 7JcEUuwvtQgNyVtzpX2/vyts8tNNmcqOWOyXXKJiylC/ZfnZIgvTZDbIEfCgOo3TRU+A dMrCcW2DaffiDJhVf0cDlltwi+G6XQ6UIWWtyjNhvNSB2DWpW/2T0Ei7WNNxtC5JSKcV ifdg5xkLd8my5MSkUuKthiVMHJNve/LJuhf9xa/2GVcO4KamtUfFpEtUcQr1BfESmuJA 3f3sPHxWlZlfY2tXB6H4Or7pZDIZ52qGj4ETubQJF+iD0tnztFhbEMfFZTwJCK5q0Pyl NYyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm27si1388065edb.248.2020.06.11.03.29.32; Thu, 11 Jun 2020 03:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbgFKK0u (ORCPT + 99 others); Thu, 11 Jun 2020 06:26:50 -0400 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:44774 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgFKK0u (ORCPT ); Thu, 11 Jun 2020 06:26:50 -0400 Received: from [192.168.178.27] (unknown [87.147.49.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id D3596580065; Thu, 11 Jun 2020 12:26:46 +0200 (CEST) Subject: Re: [PATCH] ath10k: fix retry packets update in station dump To: Venkateswara Naralasetty , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org References: <1591856446-26977-1-git-send-email-vnaralas@codeaurora.org> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBF7QuV0BEACYaiAXGmLtuHHqn37GUkDV2K7DSvTSZlPQ5q1DJSVS5mPyFtqqWeQr5jEM lrG5sSLSQdQqVDrKB9brno0u2yVYmQs+QY9wgrIrDBeDX+tHmKUDioN+EFpwSFhgBJ1ZDaj2 XhhhGUdqZrKRzHgHeTCHJGyViOwHAcJoghwfOkR2dYNj6h2nQn+CZkNabG7WK9Q/GSMcWb3k 9qpmaHiuFq/qLQZqIzmzoT2bravkOFE6sdGg2ulCj9maYMKcX5mXdn/khWpDYkm4rXOB8N2Z X9Rc7DrBVSoVfP0tRM3IBG2hIfxgSNfPGVZg8yzU89QUNi1cFk3qDwjNXmQ5M3rYSAMXbzGg nb4mXqriWSXcBUMqQ1QlsWyjT5LMbcYBfkKraHS8Fhi5STmtbq/FO+FtKDqPF6mXN7h1ZHR3 Z6jOJfNANGsi0czdu4r44IB9uBoiNnZHUx9zh1yywLogb35PrAu5AkDPDaX++tUnq7EjX1BX H9ae/A0pJIzPgwia//j/jQ5EFtdgS9GfCdUCKwTMJj6vfl5/FfELtDTAV/5Fu25AlZYmQSlO MJ2Sj4xBRc7b3zuWphUzlHTAtzPq69/LnzFLB+B5VzdjUEwvVfLjbQ6CNoxiLaFyxJVZjJ/W tQJNzmhouySGukGIHOZ0ysIzIv05rsdcYkqTpZ4BK4Rgm5OIxQARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCVAQTAQgAPhYhBM1AqapFjl1qb/Dg XGQqfNcw1BBwBQJe0LldAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGQq fNcw1BBwdQoP/jDdTh3giO9c6xEVCuf9VLIHtHUD3rjcP+itTwz43kMbda0zhpxBOOS07WDe 4wSJFbw6qaMIf0pBzclFc5t91pdUtU7s1xq/iPkIpOV0DRA0nOqgF9f8kE20foK1yU9T3FKO iZA4IPASTqfUar7NZYXsiBmFM9UY922N7oIuOa14g6uBTtOzBL2bTheQ4LclYCsMAf3HsfbR EgUNIZlCYBeEosaUGnwAwy2bOw/GRE2WD3TDF5Ks1vidC4SdFCcvFjL2QkBdVguxFD9exv0d xAbwR4cLIaHRP9p3i0Y66k4OpecY7ryDsqHl+tu1RU9Wy/qFTQqo/EWIkNW0YXprI1/amrIK MXnQpI/8mxzlHaG/9T6tUXlBAMvauUN6lnEme7iiJkbqyCWGh1DuSFqKDpoIzzfs0rYschkd lJiPw4c+KuL2ivh+2QELm3SUL+oVdk/c1aoqj1kya4AnBKE14k8qy8Gacp6utlLKEKLbempf siE5GZJoWYe3z0Gjb1wrYhjitDxT3XJKBGw6kPWNFFBbbFxMOuMB2cbw2QLKyOJSYDRWHG/0 VqzDNt9SXfTpALlgymhrf9QppWq/hDmhkjICioxgw3GnmXulGFZU9u3W9jkmQkjkEvmPkief NOc4+hMNpZ5qTPwqYHnik1mOKavDEraDC4ypcH2R/raZdoVJuQINBF7QuV0BEADcbS5GNqGF KR9HJUDXueLs7jgbelO8ITJnRfEv3xMFN7dysOSZueMfSkXaLEuHu0hiy2J4OaqS8TH87e2r d3fgCeG5sdosZ3qtXQuWcvgxKI1nOj0q2AD8pyaJEUyrPxrzDMYoWK7GW59iOyFBWBCH48zG f5MjUH/kCgOoU9yAUP8mR8JM5PG/ZOc5tnUyiylGlFohcfeTLeVoCou8XiaV+7poUJk5XBgB 17+eQsI45rjyiCFpVbCmXYxNggaHhdYYLllkpO4YkSn2aaY4LRxjg0Dz0srfsPEvphN/C519 xJbTNOOY500Cp0tETXBzJ8PBGBn4SIerygviLRWO90g+AS6J6wz8LVnJexPR8w+QlbFwUO/7 uvm2RqwEv+nc1V42Gr5Mx0Tsqi4usSA0Sb+wDPPjR+e33BYbT/7FI7dUiSa6zRSACPkMQNpE yrL7dB/+pPcleT3a+h4RimF9kVgLW8nWFX3Tf+GaqryjhzgWtyGm4IVxn1e2HtLe/jM7mWKn U19E5dqL7LcljU3w7C5ic2RezHqGWFkLcvBSDVkV+mXD2sXuXKlWDR1bWcoQ33igC4xA9y+Z qt9jJuSqjleSEqf2M431bacWDjRFMcntDPZ2toNI0MwTEVpTGMcmCl2P3hvFziTYXs+t8Qac b9m7ACze7qVV86k8Hrf49oUu3wARAQABiQI8BBgBCAAmFiEEzUCpqkWOXWpv8OBcZCp81zDU EHAFAl7QuV0CGwwFCQlmAYAACgkQZCp81zDUEHCJcQ/+KGDu2a5Z+a2Di71FnobSWBeG8q1n twVOErcBacwC/UmRdXzJb27FxwsJf1mhp7wvzEp+OVVAa2R5zYLiAuIroJuB5ezzKE98qpEp d6A2zWwQjGBxEHvFm33mXRZndEy7mSzQl7KL5qlXQwW2dNoYDH7K/F7EVhD5VYSroMQnytst uqsKzGMsSIpo8wvZsaqWQbRmV2FU3DeI+m7KVCPFQUgKa4imgDHcknxqQ5CgVYbSnWLzdjs0 /IAJHkA5ES/dAgEodMw/q9kFnuvURn+UOqS/G8+JhVb2P2SWUSX62vE9bJpSxjXCOWxh+09S HKjxz2SJO80jJTq0JXyHgQwKh0frtzdj3MBVheC++3qnl+Tb/uf2Y492zlR/P9JpoYXaliCR 7kXmhjiYJO1hoV04XPQAZJyx3/ll3rwT9dRX9K8+RAc7DWd71Sa+0A6EUaKZ+IxpN2h0gHOc ynyZfh78dp/+Il4IpgMtewA3aRYzjsnAuisUcgqFiEDUAhYxeJo3qYcewbb6u1lj9mZJj4Hw 4hhZ0lPC3oNT4a4V4IJX5+WRWcRFgrZjSAJE1VgMeqbBIK4qajpX3ugXpoBb/m2/JLIeP+Yf DNjaaWVQV4QO+ibYz1Kay6Y4+M1NhxrlyfhdfuOWu5FLuDRww14hdF2Y6MbIFOY33Al7hCy9 HbCBIiM= Message-ID: Date: Thu, 11 Jun 2020 12:26:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1591856446-26977-1-git-send-email-vnaralas@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/11/20 8:20 AM, Venkateswara Naralasetty wrote: > When tx status enabled, retry count is updated from tx completion status. > which is not working as expected due to firmware limitation where > firmware can not provide per MSDU rate statistics from tx completion > status. Due to this tx retry count is always 0 in station dump. > > Fix this issue by updating the retry packet count from per peer > statistics. This patch will not break on SDIO devices since, this retry > count is already updating from peer statistics for SDIO devices. > > HW used: QCA9984 > FW version: 10.4-3.6-00104 Thanks a lot for this patch! I tested it on the following HW, where it also works. HW: QCA9882 FW: 10.2.4-1.0-00047 Markus