Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1698090ybt; Mon, 15 Jun 2020 07:13:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlJbH2m3TYojVytORAuweaCsYXkmR788J0OB75aWkV5yoP3DesfMIYg2iXta+R+Lw5Ko8/ X-Received: by 2002:a50:fe07:: with SMTP id f7mr24464911edt.315.1592230424771; Mon, 15 Jun 2020 07:13:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592230424; cv=none; d=google.com; s=arc-20160816; b=Ox8dXwGSSAuXmCDDU6BAClFbI4X6S+UoTMWE72xJj8pkZdChuTPP7RR05/Ov9ARIK0 myVHa7ws1r4p4wRs3hyUi/WuyYwe5BcMAy8Q7+7auzVL/2f793nSD0Vhy5BZTN8waXwX IKPiXwk3M1h2CKNTJuF6/7emdOb3tIrZHPy4Tl2Hal6jQsjOD7JdHXI2PxJi8JjMg8Df hxS/ms6ElsK8bgwHV4qh5PeYAd4Nf7n1Pf0BgXUI0CBQFLBKrc/80e+TMLxYCdY58UIn tNtPQLcYwdzzFwzAl9QGViNdQZxTrgCfn2aA0Ol/pIKaa/qkIaWR5u5CZqCBljzwBzFP pJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=1Pf8qgDlo60ZypqXv8y3V9WbP4WNZCQp59/VV7KR3EI=; b=IoWLhOngiZebD7ukKL0HIcIxouA2P4eOQLtastnOCIN9S0H+zGyotI7njCtu7+c85l iz1rwwP3btoSKBQsassPxqOnt57SiahcCuf3qGVxPxFATuOk6shT8lBPOBk6dwPAdXxU WpRdy4NzlCepcSUhErYmg1C6YRlsFoTEsGRJfi31KwsntC1zLBadxzb6ApUEozM0xBl8 Csfa4z1ZxyvSVMKd99hRiJmSA+c+VHiCWF40z81UTSPFz+8NUKSr+0z6R67swDwt8xYj FWSwfkjzDvaowGMRFBYmu/1rmoQz0xAJgPqrhLthb0rikSO2binNI1kgiPIk+WQiSy1G j/+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=bw1TSdEe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk14si8495984edb.0.2020.06.15.07.13.11; Mon, 15 Jun 2020 07:13:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=bw1TSdEe; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbgFOOKP (ORCPT + 99 others); Mon, 15 Jun 2020 10:10:15 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:56297 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbgFOOKO (ORCPT ); Mon, 15 Jun 2020 10:10:14 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592230213; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=1Pf8qgDlo60ZypqXv8y3V9WbP4WNZCQp59/VV7KR3EI=; b=bw1TSdEeWjtN/fRBNnmf/Oul+JfpjpcfGotU01BBc//EA3pMrvRRD1oXsSGjXTdiV+8d+P76 peeDg3oS/ojkEvca/pPNM1A9/uFaxdcevHr6EfgPj1mYnEkTVqKM37Pg3QP2U+iebPzzJb3o BEkzMuWEP40EiyqKyOPc6Az+SJU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5ee7813bad153efa349428a9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 15 Jun 2020 14:10:03 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 32F7FC433CB; Mon, 15 Jun 2020 14:10:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 26519C433CA; Mon, 15 Jun 2020 14:10:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 26519C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v5.7 8/8] iwlwifi: mvm: don't call iwl_mvm_free_inactive_queue() under RCU From: Kalle Valo In-Reply-To: References: To: Luca Coelho Cc: linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200615141003.32F7FC433CB@smtp.codeaurora.org> Date: Mon, 15 Jun 2020 14:10:03 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho wrote: > From: Johannes Berg > > iwl_mvm_free_inactive_queue() will sleep in synchronize_net() under > some circumstances, so don't call it under RCU. There doesn't appear > to be a need for RCU protection around this particular call. > > Cc: stable@vger.kernel.org # v5.4+ > Signed-off-by: Johannes Berg > Signed-off-by: Luca Coelho I'll queue this for v5.8. -- https://patchwork.kernel.org/patch/11472099/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches