Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2571726ybt; Mon, 22 Jun 2020 01:35:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpBOSk7pfU1nqUdWzVuZGnesRRQlgN6TUoPLgkZ5XYFyc1tHjj12v1e4Ayw0W/GzhKAkp2 X-Received: by 2002:a50:c44b:: with SMTP id w11mr16518457edf.317.1592814946140; Mon, 22 Jun 2020 01:35:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592814946; cv=none; d=google.com; s=arc-20160816; b=mP+9qDgu8bRsDA4b5f4nwGtpTZZRxN04K2cO9v8ZI1NX7FSBB7pZ0cBgrUvj9etQkx 2vlTgNG2iyW9feaMsxWRXoe8hGcy2lzzBnhbVuurX4DtLgsl5NtaZQdnulLRi7wbvCek 5LqO+E582SoerL4cSAEHD1atYc9GYbd7S2XaDjjxoPilRh+2pqqZX6uhbED4Ta3YWS2K 0KBNCBgRvMeuRQ+i2VjSESiE8MFkh0pign+sNCJAUmE/9wJFYQsx1/TeWZohVhARAr29 PgIODsvWDNAE7dmkDmo6pftd16AQ0lKbGkXsqwqtBFNAz+Vu1zcK2lYJlPTt9st2oxpS Bnvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=f3oYpDZdLRQzdTr4CuXK/GL2fahArasgd+wCziGuQ+g=; b=jW2RXx2vbOvcgZPhU5tcHstdf6Bek22eDUzlBS7ipWXNwlAJkcSmPBkcDIvJJGFP5H oVEw7KxXw4nyRGIj9BcJaX4YywF3BpxOb0W2pxnCDE5vc1FJkg4tLMqwKPIjMektT92O JR0aNy39Fx9FdpNfxp3402702EJTyEvwaccWbEUmTobuuLC66Vy5tXCP/dMj2PeyLixu BMINIdOrSQC9wzTNiZFq4HhlS5+e4nelEuse68RP7LB90vLxnDHHnyGxwpVbgPq80+Ap wa+PzS4cgqbJkFdneagOIA8/B3vTlLrejQKs1bwkk4tfWt4QFlt6L1QGLu0oFUvEQl/z CukQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si9158917edw.311.2020.06.22.01.35.22; Mon, 22 Jun 2020 01:35:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726023AbgFVIeq (ORCPT + 99 others); Mon, 22 Jun 2020 04:34:46 -0400 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:55582 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgFVIep (ORCPT ); Mon, 22 Jun 2020 04:34:45 -0400 Received: from [192.168.178.40] (unknown [79.211.69.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 0735C580080; Mon, 22 Jun 2020 10:34:41 +0200 (CEST) Subject: Re: [PATCH] mac80211: fix control port tx status check To: Johannes Berg Cc: linux-wireless@vger.kernel.org, j@w1.fi References: <20200622083054.102643-1-markus.theil@tu-ilmenau.de> <537bd31e3dcef148fcc934969c782e0f0c40d711.camel@sipsolutions.net> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBF7QuV0BEACYaiAXGmLtuHHqn37GUkDV2K7DSvTSZlPQ5q1DJSVS5mPyFtqqWeQr5jEM lrG5sSLSQdQqVDrKB9brno0u2yVYmQs+QY9wgrIrDBeDX+tHmKUDioN+EFpwSFhgBJ1ZDaj2 XhhhGUdqZrKRzHgHeTCHJGyViOwHAcJoghwfOkR2dYNj6h2nQn+CZkNabG7WK9Q/GSMcWb3k 9qpmaHiuFq/qLQZqIzmzoT2bravkOFE6sdGg2ulCj9maYMKcX5mXdn/khWpDYkm4rXOB8N2Z X9Rc7DrBVSoVfP0tRM3IBG2hIfxgSNfPGVZg8yzU89QUNi1cFk3qDwjNXmQ5M3rYSAMXbzGg nb4mXqriWSXcBUMqQ1QlsWyjT5LMbcYBfkKraHS8Fhi5STmtbq/FO+FtKDqPF6mXN7h1ZHR3 Z6jOJfNANGsi0czdu4r44IB9uBoiNnZHUx9zh1yywLogb35PrAu5AkDPDaX++tUnq7EjX1BX H9ae/A0pJIzPgwia//j/jQ5EFtdgS9GfCdUCKwTMJj6vfl5/FfELtDTAV/5Fu25AlZYmQSlO MJ2Sj4xBRc7b3zuWphUzlHTAtzPq69/LnzFLB+B5VzdjUEwvVfLjbQ6CNoxiLaFyxJVZjJ/W tQJNzmhouySGukGIHOZ0ysIzIv05rsdcYkqTpZ4BK4Rgm5OIxQARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCVAQTAQgAPhYhBM1AqapFjl1qb/Dg XGQqfNcw1BBwBQJe0LldAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGQq fNcw1BBwdQoP/jDdTh3giO9c6xEVCuf9VLIHtHUD3rjcP+itTwz43kMbda0zhpxBOOS07WDe 4wSJFbw6qaMIf0pBzclFc5t91pdUtU7s1xq/iPkIpOV0DRA0nOqgF9f8kE20foK1yU9T3FKO iZA4IPASTqfUar7NZYXsiBmFM9UY922N7oIuOa14g6uBTtOzBL2bTheQ4LclYCsMAf3HsfbR EgUNIZlCYBeEosaUGnwAwy2bOw/GRE2WD3TDF5Ks1vidC4SdFCcvFjL2QkBdVguxFD9exv0d xAbwR4cLIaHRP9p3i0Y66k4OpecY7ryDsqHl+tu1RU9Wy/qFTQqo/EWIkNW0YXprI1/amrIK MXnQpI/8mxzlHaG/9T6tUXlBAMvauUN6lnEme7iiJkbqyCWGh1DuSFqKDpoIzzfs0rYschkd lJiPw4c+KuL2ivh+2QELm3SUL+oVdk/c1aoqj1kya4AnBKE14k8qy8Gacp6utlLKEKLbempf siE5GZJoWYe3z0Gjb1wrYhjitDxT3XJKBGw6kPWNFFBbbFxMOuMB2cbw2QLKyOJSYDRWHG/0 VqzDNt9SXfTpALlgymhrf9QppWq/hDmhkjICioxgw3GnmXulGFZU9u3W9jkmQkjkEvmPkief NOc4+hMNpZ5qTPwqYHnik1mOKavDEraDC4ypcH2R/raZdoVJuQINBF7QuV0BEADcbS5GNqGF KR9HJUDXueLs7jgbelO8ITJnRfEv3xMFN7dysOSZueMfSkXaLEuHu0hiy2J4OaqS8TH87e2r d3fgCeG5sdosZ3qtXQuWcvgxKI1nOj0q2AD8pyaJEUyrPxrzDMYoWK7GW59iOyFBWBCH48zG f5MjUH/kCgOoU9yAUP8mR8JM5PG/ZOc5tnUyiylGlFohcfeTLeVoCou8XiaV+7poUJk5XBgB 17+eQsI45rjyiCFpVbCmXYxNggaHhdYYLllkpO4YkSn2aaY4LRxjg0Dz0srfsPEvphN/C519 xJbTNOOY500Cp0tETXBzJ8PBGBn4SIerygviLRWO90g+AS6J6wz8LVnJexPR8w+QlbFwUO/7 uvm2RqwEv+nc1V42Gr5Mx0Tsqi4usSA0Sb+wDPPjR+e33BYbT/7FI7dUiSa6zRSACPkMQNpE yrL7dB/+pPcleT3a+h4RimF9kVgLW8nWFX3Tf+GaqryjhzgWtyGm4IVxn1e2HtLe/jM7mWKn U19E5dqL7LcljU3w7C5ic2RezHqGWFkLcvBSDVkV+mXD2sXuXKlWDR1bWcoQ33igC4xA9y+Z qt9jJuSqjleSEqf2M431bacWDjRFMcntDPZ2toNI0MwTEVpTGMcmCl2P3hvFziTYXs+t8Qac b9m7ACze7qVV86k8Hrf49oUu3wARAQABiQI8BBgBCAAmFiEEzUCpqkWOXWpv8OBcZCp81zDU EHAFAl7QuV0CGwwFCQlmAYAACgkQZCp81zDUEHCJcQ/+KGDu2a5Z+a2Di71FnobSWBeG8q1n twVOErcBacwC/UmRdXzJb27FxwsJf1mhp7wvzEp+OVVAa2R5zYLiAuIroJuB5ezzKE98qpEp d6A2zWwQjGBxEHvFm33mXRZndEy7mSzQl7KL5qlXQwW2dNoYDH7K/F7EVhD5VYSroMQnytst uqsKzGMsSIpo8wvZsaqWQbRmV2FU3DeI+m7KVCPFQUgKa4imgDHcknxqQ5CgVYbSnWLzdjs0 /IAJHkA5ES/dAgEodMw/q9kFnuvURn+UOqS/G8+JhVb2P2SWUSX62vE9bJpSxjXCOWxh+09S HKjxz2SJO80jJTq0JXyHgQwKh0frtzdj3MBVheC++3qnl+Tb/uf2Y492zlR/P9JpoYXaliCR 7kXmhjiYJO1hoV04XPQAZJyx3/ll3rwT9dRX9K8+RAc7DWd71Sa+0A6EUaKZ+IxpN2h0gHOc ynyZfh78dp/+Il4IpgMtewA3aRYzjsnAuisUcgqFiEDUAhYxeJo3qYcewbb6u1lj9mZJj4Hw 4hhZ0lPC3oNT4a4V4IJX5+WRWcRFgrZjSAJE1VgMeqbBIK4qajpX3ugXpoBb/m2/JLIeP+Yf DNjaaWVQV4QO+ibYz1Kay6Y4+M1NhxrlyfhdfuOWu5FLuDRww14hdF2Y6MbIFOY33Al7hCy9 HbCBIiM= Message-ID: Date: Mon, 22 Jun 2020 10:34:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <537bd31e3dcef148fcc934969c782e0f0c40d711.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/22/20 10:33 AM, Johannes Berg wrote: > On Mon, 2020-06-22 at 10:30 +0200, Markus Theil wrote: >> Signed-off-by: Markus Theil >> --- >> net/mac80211/status.c | 21 ++++++++++++++------- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/net/mac80211/status.c b/net/mac80211/status.c >> index 7b1bacac39c6..88c826645903 100644 >> --- a/net/mac80211/status.c >> +++ b/net/mac80211/status.c >> @@ -639,11 +639,22 @@ static void ieee80211_report_ack_skb(struct ieee80211_local *local, >> u64 cookie = IEEE80211_SKB_CB(skb)->ack.cookie; >> struct ieee80211_sub_if_data *sdata; >> struct ieee80211_hdr *hdr = (void *)skb->data; >> + u16 ethertype = 0xffff; >> + >> + if (skb->protocol == cpu_to_be16(ETH_P_802_3) && skb->len >= 14) >> + ethertype = (skb->data[12] << 8) | skb->data[13]; > Might be nicer to extract that as __be16 immediately? > > johannes > > Makes sense. I'll send an update.