Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] brcmfmac: Set pacing shift before transmitting skb to
 bus
To:     Wright Feng <wright.feng@cypress.com>,
        linux-wireless@vger.kernel.org
Cc:     brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@codeaurora.org>, chi-hsien.lin@cypress.com
References: <20200622020721.498-1-wright.feng@cypress.com>
 <20200622020721.498-3-wright.feng@cypress.com>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <83f89386-f5ae-91ef-d135-a1a0c9a55acb@broadcom.com>
Date:   Mon, 22 Jun 2020 10:57:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200622020721.498-3-wright.feng@cypress.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 6/22/2020 4:07 AM, Wright Feng wrote:
> Linux 3.6 introduces TSQ which has a per socket threshold for TCP Tx
> packet to reduce latency. In flow control mode, host driver enqueues skb
> in hanger and TCP doesn't push new skb frees until host frees the skb when
> receiving fwstatus event. So set pacing shift 8 to send them as a single
> large aggregate frame to the bus layer.
> 
> 43455 TX TCP throughput in FC mode 2 on Linux 5.4.18
> sk_pacing_shift : Throughput
> 10: 190 Mbps
>   9: 216 Mbps
>   8: 233 Mbps (Max throughput)
>   7: 233 Mpbs

In this patch the pacing shift update is done irrespective of the FC 
mode so I would like to see similar measurements for the other FC mode 
configurations.

Regards,
Arend