Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 907CCC433CA
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Reto Schneider <code@reto-schneider.ch>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] rtl8192cu: Fix deadlock
References: <20200622132113.14508-1-code@reto-schneider.ch>
        <20200622132113.14508-2-code@reto-schneider.ch>
        <6f1000a0-7a0a-36c9-21a3-1ea39175d051@lwfinger.net>
Date:   Tue, 23 Jun 2020 12:20:46 +0300
In-Reply-To: <6f1000a0-7a0a-36c9-21a3-1ea39175d051@lwfinger.net> (Larry
        Finger's message of "Mon, 22 Jun 2020 13:01:26 -0500")
Message-ID: <87k0zydtox.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 6/22/20 8:21 AM, Reto Schneider wrote:
>> Prevent code from calling itself indirectly, causing the driver to hang
>> and consume 100% CPU.
>>
>> Without this fix, the following script can bring down a single CPU
>> system:
>> ```
>> while true; do
>>    rmmod rtl8192cu
>>    modprobe rtl8192cu
>> done
>> ```
>>
>> Signed-off-by: Reto Schneider <code@reto-schneider.ch>
>
> I have one small comment. Patches for the rtlwifi family of drivers
> have patch subjects of the form [PATCH] rtlwifi: rtl8192cu: blah blah.
> I'll let Kalle decide if he wants ignore my comment, manually change
> the subjects, or request a V2. Otherwise all 3 patches are OK.

I can fix the titles during commit.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches