Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 23 Jun 2020 13:51:55 -0700
From:   Rajkumar Manoharan <rmanohar@codeaurora.org>
To:     P Praneesh <ppranees@codeaurora.org>
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] mac80211: avoid bss color setting in non-he mode
In-Reply-To: <1592383348-19266-1-git-send-email-ppranees@codeaurora.org>
References: <1592383348-19266-1-git-send-email-ppranees@codeaurora.org>
Message-ID: <11461228fd45ffeb89cbd5e532d6386d@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-06-17 01:42, P Praneesh wrote:
> Adding bss-color configuration for HE mode alone.
> Earlier we have enabled it by default, irrespective
> of capabilities. But bss-color feature is only for
> HE mode. Hence avoiding this by adding bss-color flag
> only for HE mode.
> 
> Signed-off-by: P Praneesh <ppranees@codeaurora.org>
> ---
>  net/mac80211/cfg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 548a384..2c5847d 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -992,8 +992,7 @@ static int ieee80211_start_ap(struct wiphy *wiphy,
> struct net_device *dev,
>  		      BSS_CHANGED_P2P_PS |
>  		      BSS_CHANGED_TXPOWER |
>  		      BSS_CHANGED_TWT |
> -		      BSS_CHANGED_HE_OBSS_PD |
> -		      BSS_CHANGED_HE_BSS_COLOR;
> +		      BSS_CHANGED_HE_OBSS_PD;
> 
Why not other HE flags?

>  	int i, err;
>  	int prev_beacon_int;
> 
> @@ -1019,6 +1018,7 @@ static int ieee80211_start_ap(struct wiphy
> *wiphy, struct net_device *dev,
>  		sdata->vif.bss_conf.frame_time_rts_th =
>  			le32_get_bits(params->he_oper->he_oper_params,
>  			      IEEE80211_HE_OPERATION_RTS_THRESHOLD_MASK);
> +		changed |= BSS_CHANGED_HE_BSS_COLOR;
> 
Praneesh,

I see that BSS color is not disabled when NL80211_ATTR_HE_BSS_COLOR is 
not set.
I think this must be fixed in cfg80211.

-Rajkumar