Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0BsXhligtE6TpCXcHuWvqZJ39zFFuymFx7Eb53kKqNgm8sDIMEAymxlymPLv/xb+0/jzczQLpd
 dTpiXZPm5GVcbpoABOclqPVKjY+2qVOzMJRQQ4nPB2XH16BZ4kC7e/ysIOq+gxdaANptZ1ejPd
 Bpt+Zni04NqYmeF5VxIlVCM1qTcAjStbYFPGwCVFqkRe68qCOS7t+2PZvsoKW4SO3JxWcbH9v3
 Xtg2EM2vTc6UHiBtg9Af2zBGYk/ni/BhPstASqg9SoyPdVpvdrWsYooaK8VbMH7VOkKMeIJAR9
 2Y0=
From:   <Ajay.Kathat@microchip.com>
To:     <lkp@intel.com>, <linux-wireless@vger.kernel.org>
CC:     <kbuild-all@lists.01.org>, <devel@driverdev.osuosl.org>,
        <Venkateswara.Kaja@microchip.com>, <gregkh@linuxfoundation.org>,
        <Nicolas.Ferre@microchip.com>, <johannes@sipsolutions.net>,
        <Sripad.Balwadgi@microchip.com>
Subject: Re: [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for
 wilc1000 compilation
Thread-Topic: [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for
 wilc1000 compilation
Thread-Index: AQHWSU15j3LzKe0p40qXGuHZhF86hqjmSUqAgAD0N4A=
Date:   Wed, 24 Jun 2020 05:26:49 +0000
Message-ID: <d9ab0945-f993-c12e-bfcf-d1467b2b683b@microchip.com>
References: <20200623110000.31559-18-ajay.kathat@microchip.com>
 <202006232255.SJ9vbMlt%lkp@intel.com>
In-Reply-To: <202006232255.SJ9vbMlt%lkp@intel.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <FDEAF570C4AADD4A8AEE583AB544365E@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 491a00e2-6f68-4d09-a1a5-08d817ff3251
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 05:26:49.9735
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SJpbkmmpkbUcqa05Ze+SeuydB2zDge3GIqSGrTFCZGXjqCSVoDwsZYxXPuRIRBaNFG7ctEkzSkBbB8sl6iJTLmhGdeYjN/Kzrju3FG7iybU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3598
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 23/06/20 8:22 pm, kernel test robot wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content is safe
>=20
> Hi,
>=20
> I love your patch! Perhaps something to improve:
>=20
> [auto build test WARNING on a15a20acc980342c97d804c5fae1cfc0cd7712a9]
>=20
> url:    https://github.com/0day-ci/linux/commits/Ajay-Kathat-microchip-co=
m/wilc1000-move-out-of-staging/20200623-190333
> base:    a15a20acc980342c97d804c5fae1cfc0cd7712a9
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=3D1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros=
s ARCH=3Dia64
>=20
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>=20
> All warnings (new ones prefixed by >>):
>=20
>    drivers/net/wireless/microchip/wilc1000/mon.c: In function 'wilc_wfi_i=
nit_mon_interface':
>>> drivers/net/wireless/microchip/wilc1000/mon.c:232:2: warning: 'strncpy'=
 specified bound 16 equals destination size [-Wstringop-truncation]
>      232 |  strncpy(wl->monitor_dev->name, name, IFNAMSIZ);
>          |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Though replacing 'strncpy' with 'strlcpy' will help to suppress this
warning but not sure if its true alarm because next line sets NULL
termination for string.
I agree 'strlcpy' is better candidate here and reduces one extra line.

>=20
> vim +/strncpy +232 drivers/net/wireless/microchip/wilc1000/mon.c
>=20
> daf8b5f14a7066 Ajay Singh 2020-06-23  216
> daf8b5f14a7066 Ajay Singh 2020-06-23  217  struct net_device *wilc_wfi_in=
it_mon_interface(struct wilc *wl,
> daf8b5f14a7066 Ajay Singh 2020-06-23  218                                =
              const char *name,
> daf8b5f14a7066 Ajay Singh 2020-06-23  219                                =
              struct net_device *real_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  220  {
> daf8b5f14a7066 Ajay Singh 2020-06-23  221       struct wilc_wfi_mon_priv =
*priv;
> daf8b5f14a7066 Ajay Singh 2020-06-23  222
> daf8b5f14a7066 Ajay Singh 2020-06-23  223       /* If monitor interface i=
s already initialized, return it */
> daf8b5f14a7066 Ajay Singh 2020-06-23  224       if (wl->monitor_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  225               return wl->monito=
r_dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  226
> daf8b5f14a7066 Ajay Singh 2020-06-23  227       wl->monitor_dev =3D alloc=
_etherdev(sizeof(struct wilc_wfi_mon_priv));
> daf8b5f14a7066 Ajay Singh 2020-06-23  228       if (!wl->monitor_dev)
> daf8b5f14a7066 Ajay Singh 2020-06-23  229               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  230
> daf8b5f14a7066 Ajay Singh 2020-06-23  231       wl->monitor_dev->type =3D=
 ARPHRD_IEEE80211_RADIOTAP;
> daf8b5f14a7066 Ajay Singh 2020-06-23 @232       strncpy(wl->monitor_dev->=
name, name, IFNAMSIZ);
> daf8b5f14a7066 Ajay Singh 2020-06-23  233       wl->monitor_dev->name[IFN=
AMSIZ - 1] =3D 0;
> daf8b5f14a7066 Ajay Singh 2020-06-23  234       wl->monitor_dev->netdev_o=
ps =3D &wilc_wfi_netdev_ops;
> daf8b5f14a7066 Ajay Singh 2020-06-23  235       wl->monitor_dev->needs_fr=
ee_netdev =3D true;
> daf8b5f14a7066 Ajay Singh 2020-06-23  236
> daf8b5f14a7066 Ajay Singh 2020-06-23  237       if (register_netdevice(wl=
->monitor_dev)) {
> daf8b5f14a7066 Ajay Singh 2020-06-23  238               netdev_err(real_d=
ev, "register_netdevice failed\n");
> daf8b5f14a7066 Ajay Singh 2020-06-23  239               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  240       }
> daf8b5f14a7066 Ajay Singh 2020-06-23  241       priv =3D netdev_priv(wl->=
monitor_dev);
> daf8b5f14a7066 Ajay Singh 2020-06-23  242       if (!priv)
> daf8b5f14a7066 Ajay Singh 2020-06-23  243               return NULL;
> daf8b5f14a7066 Ajay Singh 2020-06-23  244
> daf8b5f14a7066 Ajay Singh 2020-06-23  245       priv->real_ndev =3D real_=
dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  246
> daf8b5f14a7066 Ajay Singh 2020-06-23  247       return wl->monitor_dev;
> daf8b5f14a7066 Ajay Singh 2020-06-23  248  }
> daf8b5f14a7066 Ajay Singh 2020-06-23  249
>=20
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> =