Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b57135152b6d88729b23d9a8d9726a59f0ed44cc.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: flush scan entries upon suspend
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Luca Coelho <luca@coelho.fi>
Cc:     linux-wireless@vger.kernel.org, emmanuel.grumbach@intel.com
Date:   Thu, 25 Jun 2020 10:40:29 +0200
In-Reply-To: <iwlwifi.20200623211013.df306f28bb0f.Ib56a98fa55090cc2d9952463f2c292a0a101f3cb@changeid>
References: <iwlwifi.20200623211013.df306f28bb0f.Ib56a98fa55090cc2d9952463f2c292a0a101f3cb@changeid>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-06-23 at 21:10 +0300, Luca Coelho wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> 
> When we suspend, we can't really remember our BSS table.

Sure we can. We do today :-)

Yes, I know why you want this for iwlwifi, but this commit message isn't
good. And if you had a good commit message, you'd know that it's
actually only needed for iwlwifi, not for basically anyone else.

And, in fact, it's not even needed for iwlwifi because if you had WoWLAN
then the firmware stays running and you don't need it.

> Purge all the data.

We age it already since commit cb3a8eec0e66. That should be sufficient
for most devices.

And in fact, if it weren't, then this should have removed the ageing
that's now completely pointless :)

> Export this function to allow driver to purge the BSS table
> in case they feel the need to.
> iwlwifi will need to do that.

I think we should just have a patch to purge it, without the call in
sysfs.c, and do then iwlwifi can call it in the right places (when it
resets the firmware.)

Note this won't even be _perfect_ because there are reasons (like being
connected) that mean the entry is not removed even when flushing, so
that should probably be documented.

johannes