Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp495023ybt; Fri, 26 Jun 2020 04:41:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweZ00DNHgjBmLLWtXw79Al0WUZ2EpU2NneRENG3ImZzT69SUIE8htiaSV5d0N2H8NUZRm0 X-Received: by 2002:a05:6402:947:: with SMTP id h7mr2904897edz.213.1593171715110; Fri, 26 Jun 2020 04:41:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593171715; cv=none; d=google.com; s=arc-20160816; b=ZnInz0+bzINFEtclWXgPWhJLSCbAT9/gKM2gC5M/DvHGXn1rwbW047j3B5Wki3PxIW kWhRWsM2ZZJAigtq5/VvWqhJLJHyUOB2xlKMy4leH/R8icPH5QLC4Sbvh28xHikKLOwo EfWMxdSmTjzJo1xqtjolhLhYSd+5DnJFosRF3pJoClDsRxFp3iOdhYVXUEjnWpzNgmJ5 bUey5hPHdtjNr2AxZAmO2WemN2Km8H+M8aOLuEFfzl5R23UBf1j3SXhLbfzIyWNphrWX +FULwE82YYFw1H790sAAVPfbR/bZCwzFD5uQ1F85vOtpgRAOyYOyWXbS0V+SZ358pTZF YmPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=qkW0om8OMIw1Mro73k0uJrsmj28YQXa7EJIcrsIcD/k=; b=KyP1FvK42lVUthdKqtjIRp4+n8LGvkENtxI1wt+XsYvPmSJFxNz7YqvxGyxOARxtug YYMhqeHDTToW57WHxsfbDQRushMOwf241mG4flp17gkpAeIT0FfMFkobI14C5bo0GwS+ mVzP3g0+bEiK5k6y6P8TpeTZ+N4cbnMhR96YFN7wzuOflW52lvRnaW7NHWrdkbNIHktq qG4p0DmX2sQXx80XnI7toO96cIwIgvlfFrA4rolnckWNmAccdv4T8UX78Acm25hHejXw VYdVS/5XQ2wtEUD7ksbtUKUL3GPOOBGRJEimrT7GqMkAW92RJii8BUQpjYlffuTyZ/2b fuRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si17267348edn.360.2020.06.26.04.41.26; Fri, 26 Jun 2020 04:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbgFZJtq (ORCPT + 99 others); Fri, 26 Jun 2020 05:49:46 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:38328 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726873AbgFZJtq (ORCPT ); Fri, 26 Jun 2020 05:49:46 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=redipa.ger.corp.intel.com) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jokzP-001EwP-BS; Fri, 26 Jun 2020 12:49:44 +0300 From: Luca Coelho To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org Date: Fri, 26 Jun 2020 12:49:40 +0300 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.4 Subject: [PATCH 2/2] nl80211: fix memory leak when parsing NL80211_ATTR_HE_BSS_COLOR Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Luca Coelho If there is an error when parsing the NL80211_ATTR_HE_BSS_COLOR attribute, we return immediately without freeing param.acl. Fit it by using goto out instead of returning immediately. Fixes: 5c5e52d1bb96 ("nl80211: add handling for BSS color") Signed-off-by: Luca Coelho --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index f31698fd4a7e..0e07fb8585fb 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5025,7 +5025,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info) info->attrs[NL80211_ATTR_HE_BSS_COLOR], ¶ms.he_bss_color); if (err) - return err; + goto out; } nl80211_calculate_ap_params(¶ms); -- 2.27.0