Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 26A85C433C6
From:   "Rakesh Pillai" <pillair@codeaurora.org>
To:     "'Doug Anderson'" <dianders@chromium.org>,
        "'Kalle Valo'" <kvalo@codeaurora.org>
Cc:     <ath10k@lists.infradead.org>,
        "'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS'" 
        <devicetree@vger.kernel.org>,
        "'linux-wireless'" <linux-wireless@vger.kernel.org>,
        "'LKML'" <linux-kernel@vger.kernel.org>
References: <1593194502-13164-1-git-send-email-pillair@codeaurora.org> <1593194502-13164-3-git-send-email-pillair@codeaurora.org> <CAD=FV=V1C2Lu31n8xQ8HPf21fNo_Da2SLtZAeStFBEou9+geEA@mail.gmail.com>
In-Reply-To: <CAD=FV=V1C2Lu31n8xQ8HPf21fNo_Da2SLtZAeStFBEou9+geEA@mail.gmail.com>
Subject: RE: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting
Date:   Mon, 29 Jun 2020 17:43:35 +0530
Message-ID: <000301d64e0e$b9e32c70$2da98550$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKOP6JTmaF44S4OU0UHs+POXUh10gKWMw65AYCLAK6nXugGkA==
Content-Language: en-us
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> -----Original Message-----
> From: Doug Anderson <dianders@chromium.org>
> Sent: Saturday, June 27, 2020 3:22 AM
> To: Rakesh Pillai <pillair@codeaurora.org>; Kalle Valo
> <kvalo@codeaurora.org>
> Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-wireless =
<linux-
> wireless@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator =
supply
> voting
>=20
> Hi,
>=20
> On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai =
<pillair@codeaurora.org> wrote:
> >
> > Add support to vote for chain-1 voltage regulator
> > in WCN3990.
> >
> > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
> >
> > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> > ---
> >  drivers/net/wireless/ath/ath10k/snoc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c
> b/drivers/net/wireless/ath/ath10k/snoc.c
> > index 645ed5f..407a074 100644
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] =3D =
{
> >         "vdd-1.8-xo",
> >         "vdd-1.3-rfa",
> >         "vdd-3.3-ch0",
> > +       "vdd-3.3-ch1",
>=20
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>=20
> ...with the slight nit that ${SUBJECT} and description should probably
> call it "chan1" and not "chain1".  Presumably the maintainer can fix
> when applying.
>=20
> -Doug

Hi Doug,

It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1=20