Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1593194502-13164-1-git-send-email-pillair@codeaurora.org>
 <1593194502-13164-3-git-send-email-pillair@codeaurora.org>
 <CAD=FV=V1C2Lu31n8xQ8HPf21fNo_Da2SLtZAeStFBEou9+geEA@mail.gmail.com> <000301d64e0e$b9e32c70$2da98550$@codeaurora.org>
In-Reply-To: <000301d64e0e$b9e32c70$2da98550$@codeaurora.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 29 Jun 2020 07:33:18 -0700
Message-ID: <CAD=FV=U_qfbCQDy7DOn8VNQU+7yNn0cjS8YD232UFTXW3w3wrw@mail.gmail.com>
Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting
To:     Rakesh Pillai <pillair@codeaurora.org>
Cc:     Kalle Valo <kvalo@codeaurora.org>, ath10k@lists.infradead.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi,

On Mon, Jun 29, 2020 at 5:14 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
>
>
> > -----Original Message-----
> > From: Doug Anderson <dianders@chromium.org>
> > Sent: Saturday, June 27, 2020 3:22 AM
> > To: Rakesh Pillai <pillair@codeaurora.org>; Kalle Valo
> > <kvalo@codeaurora.org>
> > Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED
> > DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-wireless <linux-
> > wireless@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>
> > Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply
> > voting
> >
> > Hi,
> >
> > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
> > >
> > > Add support to vote for chain-1 voltage regulator
> > > in WCN3990.
> > >
> > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
> > >
> > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> > > ---
> > >  drivers/net/wireless/ath/ath10k/snoc.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c
> > b/drivers/net/wireless/ath/ath10k/snoc.c
> > > index 645ed5f..407a074 100644
> > > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {
> > >         "vdd-1.8-xo",
> > >         "vdd-1.3-rfa",
> > >         "vdd-3.3-ch0",
> > > +       "vdd-3.3-ch1",
> >
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> > ...with the slight nit that ${SUBJECT} and description should probably
> > call it "chan1" and not "chain1".  Presumably the maintainer can fix
> > when applying.
> >
> > -Doug
>
> Hi Doug,
>
> It has to be chain1 only, not chan1.
> This is the power supply rail for the wlan-chain1

Whoa, really?  "ch1" stands for "chain1", not "chan1"?  That is
seriously weird (at least to me), but I find at least one document
that agrees with you.  Sorry for the mistake!

-Doug