Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3072455ybt;
        Mon, 29 Jun 2020 14:34:25 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyVhiGeKgjydWQ3jjQzpIW3eY1Za23zr302rbq04dkk/7QSuR4LB0AsrEUZOXVi972Xxujk
X-Received: by 2002:a17:906:1c0d:: with SMTP id k13mr16352819ejg.477.1593466465791;
        Mon, 29 Jun 2020 14:34:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1593466465; cv=none;
        d=google.com; s=arc-20160816;
        b=OMkTw/xKallzZmf7UbbnXKuR5IuNptMQnd534fceFFHt2JSgC5QfPZLeJtm8MNqIT5
         RfYMRrv1C6Sww7beIbvpVqck81OMsvqgIU7KtnKzo2mh8dbS8B7hRiCYHqwdLs30Tkh0
         h9MiEsX7lzKpQBxmGwAwNWdc8B1blOWNXb1EdINTa6dhe29dABZXAsbx48nTm4ReaxfY
         V/eG1T9IpF16Djq+1g1IcqoYiKvcFWruqaqyN+xE2WH0q4lmp69HpV7YXffNWa0guXcY
         kXWwk3JUkbgL9WlLl4dxTejNAiQiZsekMRQ+mZM/npPczr2fL1htFwWkDBPlRd2coJD8
         bcnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=hOJIPbJXPvorQtrhgyqOIr37k404XP7JJGNJCE8s+Y8=;
        b=qjEzxeOF1NSXC8zC9E7l7GFQortdkvHgRtmyoLcjvJvxLELUlAiVHLfNbIAbGmBz9S
         bF46WYk/L4Lqe/saQC8vaRVhPjUv6GCfoKySkTOhlJMv1y5rEyTWeYMiFFONxWYWWVW4
         6DtLdxvWmE09xf6tEIY4AwL4w4fl6BZFEogG1YrqUdITRKjc4Jzczs7OeEhPjdfyCk4q
         /rxTHSuftQ6gf7bSBud0OYMW+pGi1rPReV/Gn0NY+Vx3KqlxWwYvp/jxSl64UG5vTtBs
         NhWm+BveE94stCBaR5wXSo2ctP4cuxXKHJUgG/n3bJ4slrwFEXhCvs1mZtDNc88jS80U
         FJRg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=MAX6lR6w;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l7si431847edr.156.2020.06.29.14.34.02;
        Mon, 29 Jun 2020 14:34:25 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=MAX6lR6w;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727109AbgF2VdI (ORCPT <rfc822;janietu502@gmail.com>
        + 99 others); Mon, 29 Jun 2020 17:33:08 -0400
Received: from mail.kernel.org ([198.145.29.99]:60606 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728638AbgF2SlD (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
        Mon, 29 Jun 2020 14:41:03 -0400
Received: from pali.im (pali.im [31.31.79.79])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 32DDC23D6A;
        Mon, 29 Jun 2020 13:26:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1593437175;
        bh=hOJIPbJXPvorQtrhgyqOIr37k404XP7JJGNJCE8s+Y8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=MAX6lR6wO0zARsIgVfVNexIL/S+5tt+gFwta5XG+JfKdCl2/tbJ4ltJxUO2OPNrKa
         GixHl/5xiVLA0/rMJNNFIA3gXA3qacdPqgt4MG48tHiIWMumQBXzIHFPtRCObTrojs
         IE9fAP73j8zkayeTR3FtmWStj0DR0SLZ9TEq4/3I=
Received: by pali.im (Postfix)
        id EE3E381F; Mon, 29 Jun 2020 15:26:12 +0200 (CEST)
Date:   Mon, 29 Jun 2020 15:26:12 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Ajay.Kathat@microchip.com
Cc:     linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, johannes@sipsolutions.net,
        Nicolas.Ferre@microchip.com, Claudiu.Beznea@microchip.com,
        Sripad.Balwadgi@microchip.com, Venkateswara.Kaja@microchip.com
Subject: Re: [PATCH v7 00/17] wilc1000: move out of staging
Message-ID: <20200629132612.nl6rfpihzlii6ilh@pali>
References: <20200623110000.31559-1-ajay.kathat@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200623110000.31559-1-ajay.kathat@microchip.com>
User-Agent: NeoMutt/20180716
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tuesday 23 June 2020 11:00:04 Ajay.Kathat@microchip.com wrote:
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code.
> Please review and provide your inputs.

Hello Ajay! Could you please move SDIO vendor/device ID definitions from
driver code wilc1000/sdio.c to common file include/linux/mmc/sdio_ids.h?

Similar cleanup was recently finished for all existing non-staging drivers:
https://lore.kernel.org/linux-mmc/20200522144412.19712-1-pali@kernel.org/