Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3554363ybt; Tue, 30 Jun 2020 05:59:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWlHVvRFmWqKq0ZIuJ1bsP3m5fbwtC3vPMeL+cuKY19jvz5oq7JaYEK4yOf+eIYiSHvYea X-Received: by 2002:a17:906:5203:: with SMTP id g3mr17558009ejm.58.1593521981894; Tue, 30 Jun 2020 05:59:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593521981; cv=none; d=google.com; s=arc-20160816; b=fQBdA1gnxjxW+/vwyPSiAV6orwLhE4qj2kXRXro6joK/YVOoZRBzX24cZQAc6HjKeC zoBVaJPqO1vwVohV4FdMiFuuC+jxUrlzbHoEE7QBkDQEZvH9C/y0S5itwlGlh3as9SWx HngYTGxt2Vv/QuFZcFsOlyMI2k6AKGhQcC2ff8pju0tmim6979fiNMC8gTYr05EnkrAQ n2J/9xOgO4m/eYZYzMDNkbMIprx3Jgf7MnJImV5n5/bx8sgesJ9AqWp8UILqaYE/+vyv x27aeAT1BxEpybqyZojgkguESiWE5/8Knq5PgNozdPxD+Z4bEPTElrHg3Yx6h94vpcSu rVpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=WwiCRMR/atAzHQdqmr8uQelMa6OcJuGWGuwIRfhRdfs=; b=tEKy+nDrwb43e4JHoUra/LFEe0KS6zPMh8AkZvuft2IParzt6NBvrwc5J2bFJxwtKT onN5htJ6bqkhuf3XTd//kJNZU3CMuQvbb4Y6enK9MfrOIcdNgElJeppXHo+FUyJyc78X tiHo0JB5GCbaWQm5+Ffw5y1iPlZZYfJQ7YuVzXDQRwnRrDg+21GkzU6d0851tWPdQGVS Fll1J9fUfIBMB0+Am/+BUIs5ZaUNizkJ1u/Yst4CUM9uunfyfxp0ME+e22SCiek3Rcd/ fMX6fosdLlwa5ZRF/XvKn59ehYvcvZm4ecL5aNeJEHJgCaS9rv6xSwpHJSUFjZdVHaKz yaGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PjtHdZDy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b10si1642996eja.426.2020.06.30.05.59.06; Tue, 30 Jun 2020 05:59:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PjtHdZDy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388094AbgF3M6M (ORCPT + 99 others); Tue, 30 Jun 2020 08:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388062AbgF3M56 (ORCPT ); Tue, 30 Jun 2020 08:57:58 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8230AC03E97E for ; Tue, 30 Jun 2020 05:57:57 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f7so17020094wrw.1 for ; Tue, 30 Jun 2020 05:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WwiCRMR/atAzHQdqmr8uQelMa6OcJuGWGuwIRfhRdfs=; b=PjtHdZDyhsfzOMknUBCzAw98LBJLOT+lMKu8FyLjhCUmY5zqFEKQjOpc0es34kiYw7 TEnUSoSJ3f61hHZTPcBVtChXqTKUT14Z1ygKNwosPCBzB0Pm7msxtjo5fYPA+1w7D3U4 JYy/2C4+NLEFNGgD3gyxAeXQqJVZpzuBvxQOI3xU1q0cTX7uddeB860HGcA+R9a2NxlU qOTSAPhfdHAEOvdlwOeQX21T5qSrN6jUZabswuo4hqHGPCBCpAOpGIbYLHfj2nkekTdR 6EPB/JQvmiyH9Shvv0lfPtAWdeC/xfUmMiaNaQy2sSG+IcFqZJPB8yJf2CCLCRJbaFfP TXnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WwiCRMR/atAzHQdqmr8uQelMa6OcJuGWGuwIRfhRdfs=; b=uPp06gtWT2xSpNQHvhTHIZnezaJfnAJ0zrsGhfav1rEtWBIexJyHUkzQVI/pJm4QaH CD6dVE5C2oxMegu9cwXJ1M6ozMtQlNFj9ieDmNznTPsP9deNYYs06FMYJML54D3sZv+A 9bjUfo65gJMpYuTBCcN0hZR1NRwFaQ5XhNJ2YXAUOD5J+u21gxJ/fMce5JgZfD+5bxnm hFIjA2B8+Gvivw2Xp3WjDDfv39jV0T+4wGZc0QiIulUVLeMkgdmdZwi23PiTiZSFzdbe QkOSansBJJi5UGdypcHRkXKs6qC5B/fnJhlKZIxQbbmPgwxG/Ijw0NZtn+GLSVRZ52Wg uwmA== X-Gm-Message-State: AOAM530wDK0FB/8it+my70lCx42oWZTr4MxSSu+ODv3QpMf0y8MZ6gcF 3WF3vDZDNNKaMBRm5ZstLc77IA== X-Received: by 2002:adf:ec42:: with SMTP id w2mr21971589wrn.269.1593521875852; Tue, 30 Jun 2020 05:57:55 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:54f4:a99f:ab88:bc07? ([2a01:e34:ed2f:f020:54f4:a99f:ab88:bc07]) by smtp.googlemail.com with ESMTPSA id 133sm3823861wme.5.2020.06.30.05.57.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 05:57:55 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices To: Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Zhang Rui , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , Bartlomiej Zolnierkiewicz , kernel@collabora.com References: <20200629122925.21729-1-andrzej.p@collabora.com> From: Daniel Lezcano Message-ID: Date: Tue, 30 Jun 2020 14:57:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629122925.21729-1-andrzej.p@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Andrzej, I've tested your series with kernelci and there are 3 regressions for the imx6. https://kernelci.org/test/job/thermal/branch/testing/kernel/v5.8-rc3-11-gf5e50bf4d3ef/plan/baseline/ On 29/06/2020 14:29, Andrzej Pietrasiewicz wrote: > A respin of v6 with these changes: > > v6..v7: > - removed duplicate S-o-b line from patch 6/11 > > v5..v6: > - staticized thermal_zone_device_set_mode() (kbuild test robot) > > v4..v5: > > - EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL (Daniel) > - dropped unnecessary thermal_zone_device_enable() in int3400_thermal.c > and in thermal_of.c (Bartlomiej) > > Andrzej Pietrasiewicz (11): > acpi: thermal: Fix error handling in the register function > thermal: Store thermal mode in a dedicated enum > thermal: Add current mode to thermal zone device > thermal: Store device mode in struct thermal_zone_device > thermal: remove get_mode() operation of drivers > thermal: Add mode helpers > thermal: Use mode helpers in drivers > thermal: Explicitly enable non-changing thermal zone devices > thermal: core: Stop polling DISABLED thermal devices > thermal: Simplify or eliminate unnecessary set_mode() methods > thermal: Rename set_mode() to change_mode() > > drivers/acpi/thermal.c | 75 +++++---------- > .../ethernet/chelsio/cxgb4/cxgb4_thermal.c | 8 ++ > .../ethernet/mellanox/mlxsw/core_thermal.c | 91 ++++--------------- > drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 9 +- > drivers/platform/x86/acerhdf.c | 33 +++---- > drivers/platform/x86/intel_mid_thermal.c | 6 ++ > drivers/power/supply/power_supply_core.c | 9 +- > drivers/thermal/armada_thermal.c | 6 ++ > drivers/thermal/da9062-thermal.c | 16 +--- > drivers/thermal/dove_thermal.c | 6 ++ > drivers/thermal/hisi_thermal.c | 6 +- > drivers/thermal/imx_thermal.c | 57 ++++-------- > .../intel/int340x_thermal/int3400_thermal.c | 38 ++------ > .../int340x_thermal/int340x_thermal_zone.c | 5 + > drivers/thermal/intel/intel_pch_thermal.c | 5 + > .../thermal/intel/intel_quark_dts_thermal.c | 34 ++----- > drivers/thermal/intel/intel_soc_dts_iosf.c | 3 + > drivers/thermal/intel/x86_pkg_temp_thermal.c | 6 ++ > drivers/thermal/kirkwood_thermal.c | 7 ++ > drivers/thermal/rcar_thermal.c | 9 +- > drivers/thermal/rockchip_thermal.c | 6 +- > drivers/thermal/spear_thermal.c | 7 ++ > drivers/thermal/sprd_thermal.c | 6 +- > drivers/thermal/st/st_thermal.c | 5 + > drivers/thermal/thermal_core.c | 76 ++++++++++++++-- > drivers/thermal/thermal_of.c | 41 +-------- > drivers/thermal/thermal_sysfs.c | 37 +------- > include/linux/thermal.h | 19 +++- > 28 files changed, 275 insertions(+), 351 deletions(-) > > > base-commit: 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68 > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog