Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/14 v3] iwlegacy: Check the return value of
 pcie_capability_read_*()
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     helgaas@kernel.org, "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, bjorn@helgaas.com,
        linux-wireless@vger.kernel.org
References: <20200710212026.27136-1-refactormyself@gmail.com>
 <20200710212026.27136-5-refactormyself@gmail.com>
 <87wo37a5s5.fsf@codeaurora.org>
From:   Saheed Bolarinwa <refactormyself@gmail.com>
Message-ID: <fa99aee8-86ee-558f-cb6f-761519c13159@gmail.com>
Date:   Mon, 13 Jul 2020 20:02:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <87wo37a5s5.fsf@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Fixed

On 7/13/20 3:44 PM, Kalle Valo wrote:
> + linux-wireless
>
> Saheed Olayemi Bolarinwa <refactormyself@gmail.com> writes:
>
>> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
>>
>> Cc: bjorn@helgaas.com,
>> 	skhan@linuxfoundation.org,
>> 	linux-pci@vger.kernel.org,
>> 	linux-kernel-mentees@lists.linuxfoundation.org,
>> 	linux-kernel@vger.kernel.org,
>> 	Stanislaw Gruszka <stf_xl@wp.pl>,
>> 	linux-wireless@vger.kernel.org,
>> 	netdev@vger.kernel.org
>>
>> On failure pcie_capability_read_dword() sets it's last parameter, val
>> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
>> failure. This would introduce a bug because (x & x) == (~0 & x).
>>
>> This bug can be avoided without changing the function's behaviour if the
>> return value of pcie_capability_read_dword is checked to confirm success.
>>
>> Check the return value of pcie_capability_read_dword() to ensure success.
>>
>> Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
>> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
> Please check your setup, linux-wireless was not in Cc field.
>
Thank you for letting me know. I have fixed it and resent to the missing 
addresses.