Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp309887ybh; Wed, 15 Jul 2020 02:33:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzyrUpcGWi+1dhE19YFe/RoqzWxNCvqmZoXVcvZDK6BkT+aiMCo6YeMI5UYuUG+q+ObXAE X-Received: by 2002:a17:906:469a:: with SMTP id a26mr8046573ejr.198.1594805586243; Wed, 15 Jul 2020 02:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594805586; cv=none; d=google.com; s=arc-20160816; b=vLx2KKZuvlSTPC3HOCsvAgAoxDTEbYKDrFmQ25edRgXLULRJ8WMzTaLdmBHRdKqsEI D3VQvQmAORe8MYYreVUpfR+KtndXrtwY9UUNOPhf54dlSr9Xxu/NmeP22e87l7OxOxFw 7dI3/BDPPOju41W3BRZAJkPL5DMbNzRH847OHwSN8UKVvXM1YlkUKqBQJl6ob4C8pAgB cUyH1XL304xESvhh2NEQ4hs5oIYDlAoN/PZiVWpwtH0mJcyUMvQDzJPtUrquIEwCnTz5 WCPdLlOjyANWikCow3J599eIl0NYb40tOUdBG3jsWOLzx7kc03iyT3FVaPiaB2p2qWZa I7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=3S7iyBl1wh3Nm0MvpG8iaSC7Y4tz2Wmy4aArmdzDCYg=; b=FaaLNRjSSnaS50R6kQ2i1vfJtqwDfeIuLgGiXkI6BpNzUsJz8TJLCDzjsTT/Oy1M9M qkkSE/pVAuzPStGLJttk4dOSDgwUc/YMkeueq9MTHlXpOMMAnCTuoeefcAB8yZzJnW6/ 4AqR0ee4hxNQVCDyuQe7kZHg8+MC4ogA15ZWmE3r4rOY9IctmiZRL09XDujGI3az79yE FsyuP/J3Vj5e6Faz8IGkNfGj5iILb08O3ywFtXk1Ki2yfig1hmpM1lQSZJU5VgN10CO9 Cb189N9gyDCTOjxgBTV5n8Xyv4ARx3O7am23T0tW6dA9n3Xr8OZ2AFqyj1Lpx3giPVqP sxEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Vf2kaQR1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si853183edw.533.2020.07.15.02.32.42; Wed, 15 Jul 2020 02:33:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Vf2kaQR1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730536AbgGOJOC (ORCPT + 99 others); Wed, 15 Jul 2020 05:14:02 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:25246 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730275AbgGOJOB (ORCPT ); Wed, 15 Jul 2020 05:14:01 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594804441; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=3S7iyBl1wh3Nm0MvpG8iaSC7Y4tz2Wmy4aArmdzDCYg=; b=Vf2kaQR1iU01C0juq9RPyfAu29ZImcBLqChJpO21yLy+mOEmOcowy4Rf9YlRGYXlkqkvUsMN MajUSolItA0RJlgxHMQsZDeQhiYFjmyhYU5ecVcVBkv0ta+9hBRXenJ2lLTJL6UVA+5z7yJ4 NyDDr7aKXOLy0Q1AQuSukBV4xEI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f0ec8ca75eeb235f652c876 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Jul 2020 09:13:46 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5FF4DC433A0; Wed, 15 Jul 2020 09:13:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 53F98C433C6; Wed, 15 Jul 2020 09:13:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 53F98C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH net-next] mwifiex: Prevent memory corruption handling keys From: Kalle Valo In-Reply-To: <20200708115857.GA13729@mwanda> References: <20200708115857.GA13729@mwanda> To: Dan Carpenter Cc: Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , Jakub Kicinski , "John W. Linville" , Bing Zhao , Nishant Sarmukadam , Marc Yang , Frank Huang , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200715091346.5FF4DC433A0@smtp.codeaurora.org> Date: Wed, 15 Jul 2020 09:13:46 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The length of the key comes from the network and it's a 16 bit number. It > needs to be capped to prevent a buffer overflow. > > Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") > Signed-off-by: Dan Carpenter > Acked-by: Ganapathi Bhat Patch applied to wireless-drivers-next.git, thanks. e18696786548 mwifiex: Prevent memory corruption handling keys -- https://patchwork.kernel.org/patch/11651443/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches