Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] ath9k: Fix regression with Atheros 9271
To:     Mark O'Donovan <shiftee@posteo.net>, linux-wireless@vger.kernel.org
Cc:     kvalo@codeaurora.org, hqjagain@gmail.com,
        ath9k-devel@qca.qualcomm.com, davem@davemloft.net, kuba@kernel.org,
        Roman Mamedov <rm@romanrm.net>
References: <20200711043324.8079-1-shiftee@posteo.net>
From:   =?UTF-8?B?VmlrdG9yIErDpGdlcnNrw7xwcGVy?= 
        <viktor_jaegerskuepper@freenet.de>
Message-ID: <184f6897-40f8-949c-eca5-2bdb0d2aa8fb@freenet.de>
Date:   Thu, 16 Jul 2020 10:01:29 +0200
MIME-Version: 1.0
In-Reply-To: <20200711043324.8079-1-shiftee@posteo.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US-large
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

[I fixed my e-mail address and CC'ed Roman]

Mark O'Donovan:
> This fix allows ath9k_htc modules to connect to WLAN once again.
> 
> Fixes: 2bbcaaee1fcb (ath9k: Fix general protection fault in
> ath9k_hif_usb_rx_cb )
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=208251
> 
> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>

This fixes the issue for me. Please don't forget:
Reported-by: Roman Mamedov <rm@romanrm.net>

And if you want to add this:
Tested-by: Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de>

These additional lines are mainly useful if the patch doesn't work for someone
else and they decide to report it, so hopefully Roman and I would receive the
report, too. And we already have three threads for this bug.

> ---
>  drivers/net/wireless/ath/ath9k/hif_usb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index 4ed21dad6a8e..3f563e02d17d 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -733,11 +733,13 @@ static void ath9k_hif_usb_reg_in_cb(struct urb *urb)
>  			return;
>  		}
>  
> +		rx_buf->skb = nskb;
> +
>  		usb_fill_int_urb(urb, hif_dev->udev,
>  				 usb_rcvintpipe(hif_dev->udev,
>  						 USB_REG_IN_PIPE),
>  				 nskb->data, MAX_REG_IN_BUF_SIZE,
> -				 ath9k_hif_usb_reg_in_cb, nskb, 1);
> +				 ath9k_hif_usb_reg_in_cb, rx_buf, 1);
>  	}
>  
>  resubmit:
>