Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <dec0f4641a13ed392a37526a812062b35e8098f1.camel@perches.com>
Subject: Re: [PATCH 01/14] rtlwifi: Replace RT_TRACE with RT_DEBUG
From:   Joe Perches <joe@perches.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>, kvalo@codeaurora.org
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 16 Jul 2020 20:32:34 -0700
In-Reply-To: <20200717020201.18209-2-Larry.Finger@lwfinger.net>
References: <20200717020201.18209-1-Larry.Finger@lwfinger.net>
         <20200717020201.18209-2-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.3-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-07-16 at 21:01 -0500, Larry Finger wrote:
> The macro name RT_TRACE makes it seem that it is used for tracing, when
> is actually used for debugging. Change the name to RT_DEBUG.
> 
> In the initial step, RT_TRACE must be kept to allow building. It will
> be removed at the end of the patch series.

Likely this patch could be broken out
so that the addition of RT_DEBUG is
patch 1 and the remainder of this patch
is patch 2.

And I'd suggest not using RT_DEBUG as the
macro but use rtl_dbg instead.

Lastly, the _rtl_dbg_trace function
should probably be renamed _rtl_dbg.

Other than that, I think this entire
series is sensible, thanks.