Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A1D6CC433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Ramon Fried <ramon.fried@gmail.com>
Cc:     Loic Poulain <loic.poulain@linaro.org>,
        wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/6] wcn36xx: Increase number of TX retries
References: <1595586052-16081-1-git-send-email-loic.poulain@linaro.org>
        <1595586052-16081-4-git-send-email-loic.poulain@linaro.org>
        <CA+Kvs9nZm+uoRJfjq33s1_nTbPt82NnEKmgYCWk0q5vH+-ca9w@mail.gmail.com>
Date:   Fri, 24 Jul 2020 16:12:39 +0300
In-Reply-To: <CA+Kvs9nZm+uoRJfjq33s1_nTbPt82NnEKmgYCWk0q5vH+-ca9w@mail.gmail.com>
        (Ramon Fried's message of "Fri, 24 Jul 2020 15:50:35 +0300")
Message-ID: <877dut5a60.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Ramon Fried <ramon.fried@gmail.com> writes:

> On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org>
> wrote:
>
>     Increase the short/long retry limit to 15 in order to impove TX
>     robustness in noisy/busy environment. 15 is the default value
>     defined in the downstream driver. Observed number of ack timeout
>     is reduced with this change.
>     
>     Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>     ---
>     drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++--
>     1 file changed, 2 insertions(+), 2 deletions(-)
>     
>     diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c
>     b/drivers/net/wireless/ath/wcn36xx/smd.c
>     index 59f9f53..908cc6c 100644
>     --- a/drivers/net/wireless/ath/wcn36xx/smd.c
>     +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
>     @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[]
>     = {
>     WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
>     WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
>     WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
>     - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6),
>     - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6),
>     + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
>     + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
>     WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
>     WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
>     WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
>     -- 
>     2.7.4
>     
>     
>     
>
> These set of patches fixed my connectivity issues with TP-Link DECO
> routers. 
> Acked-By: Ramon Fried <rfried.dev@gmail.com> 

HTML emails are dropped by the list, please use text/plain only.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches