Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2403738ybh; Fri, 24 Jul 2020 11:51:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzb+6woQ/RVkBFVnSPoJA64mLj7dVWg9Vz8oY+PVMmHL+ohu70VxSgWurfZMgGnT8828fYC X-Received: by 2002:a05:6402:13d0:: with SMTP id a16mr10122040edx.269.1595616717931; Fri, 24 Jul 2020 11:51:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595616717; cv=none; d=google.com; s=arc-20160816; b=yQ6fnEltqqVHrVOBz8UPYTKBeH3Sj0Wm4Ku0JC96scmGSp+3HpMqscd/6zqmRXbKN6 MQCIKZ8FZ14Pnt4tVK2tgEJBDVbbMKdp/wZnG7764oRY0+De9BofHu1+OUkI69yXENWS homQQnkmVfGp6Rjqr3etqkbMvuodvVHO5lZwnxIYVNXM5TwUZXXFszYF8q8ONCB+kDEM 88QxHkyozRVPWReWmgNd5/94lWbQvKrDNvUgqIg+qpd//9x+n8T13TuCpNclJ2KEjBO8 5URGyPISvhFsDOdeTTW3Aka28ouwUgmk/sIHGVWGOFiD5QzUDFxXHBCqcCtdGPlEnwPc 2VhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Bkqq/dTM1kv52hgARYE8pT8P7uaOvtiVtByu83nhzdU=; b=NILcSLD7fYnP222gtxP/oV3bgImKWD0fDbgvmQuh9mnsgw219G3tnBC3fu2PmFlT6H iUUuaSh8N2Td+MgrRRROgxsKmMYvIHJG01AR2+/PmEgxVhmUASIGJ1tGGFa7iVnAdIP6 xgkVS9kXmqrIqjYWWuufm+ttLI0YnxM+NfAxqOQ2bD0GigXQYPZbafawDQhlNfjkva/f wigi4PC+s/T1EUi51KoqR0s90duo4XYa3DfYqyQcAu8BseN0IEMJIwt381U3huqZm704 MeWE3/FMn8A+MV2c5abeM7i+JLfvZE4cAUYLBhunWsxAPwtdA6uLYCkVPuSEzRScSCse eFGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EP1pTUiD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si1201296ejb.422.2020.07.24.11.51.34; Fri, 24 Jul 2020 11:51:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=EP1pTUiD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726493AbgGXSv1 (ORCPT + 99 others); Fri, 24 Jul 2020 14:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbgGXSv1 (ORCPT ); Fri, 24 Jul 2020 14:51:27 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C666CC0619D3 for ; Fri, 24 Jul 2020 11:51:26 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id q4so4491321edv.13 for ; Fri, 24 Jul 2020 11:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bkqq/dTM1kv52hgARYE8pT8P7uaOvtiVtByu83nhzdU=; b=EP1pTUiDlNYO4WlDComc33qBRO/UcxpuLKFpZZ/5ioXdt6K2PFABeE7pTE3TYu5lV/ WOgeCT3eFHheC2Ce38LB2S3cn6WMuld9PV20Bj1Lw1wLiNZEcnmuCVcs2J2M7nnoN3aw z5x54Odum5U8P4bi3ekmdR+3K24ytjQTCxIZmZTFqg3GEqJi1q8i8QUL/paF2BP/pUoz 9CTM1S0S6FJY6Qk1FG4SsbjlnI3FP+78TCaRyn9HoxvLRBSkgrj/THvn9E2h+TgtbTFW iXXtaQtu7W8gMDGFTDrUs9fSE49HruNDhuvTKASRks484rBjnKDlxEK7ERjHVCNE0h0r GXWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bkqq/dTM1kv52hgARYE8pT8P7uaOvtiVtByu83nhzdU=; b=YBn9UHpFeeQbzYMVj6PC0z5xRhrXnW+H/H66ZMDOECvgPlFSHBNlA3SNjMDYXMhw1d 33sstmQzi1SchVq3rQ6g407NIuPXySw7DAN+vH0J2vyjVwSxJypcT+KlHI2iBy+CPL3J 7ha4ATdOjwQ33Vsq3w924ytYW5IrQT+riyjMTouk3wNwr5y4KfIEP9CyyKV9fHYuQRkF Sm5quf1tJi0DjUDnvarPMGifZ1Pbq5k3wNIRCzuilZvhMBIJM75LLC/a/N2sG/XnajDR QaRHObWrSnRHFLqp775E5/ZEgp6ezVHNvpM8taF5IgiL7LkK35nik+Jn+X4J5+LT+/99 5frA== X-Gm-Message-State: AOAM532rjf5JfVo+mi7L8fgbLtv/mlR1X+4RUqgdiVP6EWHw5m/6Wejh qoA8ZO3OXHbLFAg7tM5H234QqDZQ3kXxSBlu7OY= X-Received: by 2002:a05:6402:12d0:: with SMTP id k16mr3425104edx.199.1595616685294; Fri, 24 Jul 2020 11:51:25 -0700 (PDT) MIME-Version: 1.0 References: <1595586052-16081-1-git-send-email-loic.poulain@linaro.org> In-Reply-To: From: Ramon Fried Date: Fri, 24 Jul 2020 21:51:14 +0300 Message-ID: Subject: Re: [PATCH v2 0/6] wcn36xx misc fixes To: Loic Poulain Cc: Kalle Valo , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Jul 24, 2020 at 4:57 PM Loic Poulain wrote: > > Hi Ramon, > > On Fri, 24 Jul 2020 at 15:47, Ramon Fried wrote: > > > > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain wrote: > > > > > > This series contains various fixes for the wcn36xx driver. > > > This has been tested with wcn3620, wcn3660 and wcn3680. > > > > > > v2: - Move TX retries change into its own commit > > > - Additional patch for sequence number assignment > > > - Reword TX ack commit log (timeout detection) > > > - Fix checkpatch issues reported by Bryan > > > > > > Loic Poulain (6): > > > wcn36xx: Fix multiple AMPDU sessions support > > > wcn36xx: Add TX ack support > > > wcn36xx: Increase number of TX retries > > > wcn36xx: Fix TX data path > > > wcn36xx: Fix software-driven scan > > > wcn36xx: Use sequence number allocated by mac80211 > > > > > > drivers/net/wireless/ath/wcn36xx/dxe.c | 57 +++++++++- > > > drivers/net/wireless/ath/wcn36xx/main.c | 172 +++++++++++++++-------------- > > > drivers/net/wireless/ath/wcn36xx/smd.c | 59 ++++++++-- > > > drivers/net/wireless/ath/wcn36xx/smd.h | 12 +- > > > drivers/net/wireless/ath/wcn36xx/txrx.c | 57 ++++++---- > > > drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 7 +- > > > 6 files changed, 241 insertions(+), 123 deletions(-) > > > > > > -- > > > 2.7.4 > > > > > > > > > _______________________________________________ > > > wcn36xx mailing list > > > wcn36xx@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/wcn36xx > > > > > > Hi Loic, > > What about upstreaming the fixes for several TP-Link AP's ? > > The WCN36xx is not usable on those networks and your own tree patches seems to > > be working properly. > > Which ones do you have in mind? I didn't inspect each patch, I just took your tree and everything now works as expected on my TP-Link setup. I did notice this patch - "wcn36xx: Fix power-saving with some APs" that was missing. And there are some patches in your tree that hack the mac802111 core, Do you think there's a way to upstream those ? Thanks, Ramon. > This series normally contains the most important (and clean) patches. > > Cheers, > Loic