Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f6daeb86f2cf83f57785e08b86fecfdf6410de46.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: save he oper info in bss config for AP and
 mesh
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 30 Jul 2020 13:24:16 +0200
In-Reply-To: <20200715030937.25290-1-pradeepc@codeaurora.org> (sfid-20200715_050947_264568_478AF07B)
References: <20200715030937.25290-1-pradeepc@codeaurora.org>
         (sfid-20200715_050947_264568_478AF07B)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Please always capitalize acronyms. I might let you get away with a
lower-case "BSS" since that doesn't actually *mean* anything, but "he"
is actually an English word...

Anyway, since you haven't paid attention to the robot, I'll drop this
one way or the other.

Also,

> -u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef)
> +u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef,
> +			       struct ieee80211_sub_if_data *sdata)
>  {
>  	struct ieee80211_he_operation *he_oper;
>  	struct ieee80211_he_6ghz_oper *he_6ghz_op;
> @@ -3056,6 +3057,7 @@ u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef)
>  	he_oper = (struct ieee80211_he_operation *)pos;
>  	he_oper->he_oper_params = cpu_to_le32(he_oper_params);
>  
> +	sdata->vif.bss_conf.he_oper.params = he_oper_params;

I think these changes are inappropriate. This is a helper function to
build something, not to store the data. Please change the callers
instead.

johannes