Received: by 2002:a25:ca44:0:0:0:0:0 with SMTP id a65csp1913871ybg; Thu, 30 Jul 2020 06:07:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ7oK/sh7Fa0yoHh9TvTHO/3OqpbH4XuUlWbWbygWx1//uxXSAyYyDdf+xUUnm0uD6iOiR X-Received: by 2002:a50:e60d:: with SMTP id y13mr2513447edm.225.1596114421560; Thu, 30 Jul 2020 06:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596114421; cv=none; d=google.com; s=arc-20160816; b=w21I5AfgvOF4kTObU0XiK00DisrjqQny/jSvZI6K267wQb937Q1o8M+dg7PPHFcvBu DyIH3b2Cgd57uVjxXs17KaQ0+X7jGIOtXL8twDF7OgF7STdo6prrSoTOCDO/fgtM6KPh mKPoa+21udwK9Ro1vL5GizF1WymmORMfMPCP5f6maRdtCZrH/kFpIEh9rEon7P0RbBv6 QWcB3YjpON0u+44u7o4MYHfliojgr+sJRx/La+192leHd84U768EcEiMQWhNO04H95hY RRwekvbNYLmrIaTWO1HtCLsJsg8FWDBmxr5T96KcZ1VfMF0re/9Kurk9ZeBTc9wtJBC/ E2Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=W83fgVmSGJZNPartxNuIp4ljpblptMiIvT6VEV/crMM=; b=MOnPKj9z8CWTRI4A1VRYQwm0nO01cMo94qysd5g5Ku3I2iVT2cQHbT2S1P+5HolVcm nAMSsiNFVGlag6OsOI3330tNS7DoM8aHWcNPIp9URrW6ymkTEGR40GKFfiKuXOo/xCaz icb17ww+oaXcxufJrrneNVbw95dFchUagXxFHsxSHPiRXnI0AkMqJDFLIVQWYFsHabnv BcLNb3Yg1LLIZL2ngcQiXWV7ZBL/PUt+I2mb9c0Vc2txc2KT1lin/+GKtGTNyclLnQL+ mG6X9lDrXw8enUhIn3qBE7HiJU3/olX5MrERWi8g2030LNKHPVAgmLYCteablRHxBwzA LAMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si3179333eds.339.2020.07.30.06.06.38; Thu, 30 Jul 2020 06:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728322AbgG3NGS (ORCPT + 99 others); Thu, 30 Jul 2020 09:06:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbgG3NGR (ORCPT ); Thu, 30 Jul 2020 09:06:17 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6FD5C061794 for ; Thu, 30 Jul 2020 06:06:16 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1k18GE-00DXLG-8k; Thu, 30 Jul 2020 15:06:15 +0200 Message-ID: Subject: Re: [PATCH V2 05/10] mac80211: propagate multi bssid settings when starting From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Date: Thu, 30 Jul 2020 15:06:13 +0200 In-Reply-To: <20200706115219.663650-5-john@phrozen.org> References: <20200706115219.663650-1-john@phrozen.org> <20200706115219.663650-5-john@phrozen.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-07-06 at 13:52 +0200, John Crispin wrote: > > + memcpy(&sdata->vif.bss_conf.multi_bssid, ¶ms->multi_bssid, > + sizeof(struct ieee80211_multi_bssid)); What's wrong with struct assignments? :) sdata->vif.bss_conf.multi_bssid = params->multi_bssid; works just fine ... johannes