Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Shay Bar <Shay.Bar@celeno.com>
To:     John Crispin <john@phrozen.org>,
        Johannes Berg <johannes@sipsolutions.net>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "ath11k@lists.infradead.org" <ath11k@lists.infradead.org>
Subject: Re: [PATCH V2 06/10] ath11k: pass multiple bssid info to FW when a
 new vdev is created
Thread-Topic: [PATCH V2 06/10] ath11k: pass multiple bssid info to FW when a
 new vdev is created
Thread-Index: AQHWU4v0+suHmnhIfUW2oAR1X5YMWg==
Date:   Sun, 2 Aug 2020 15:02:23 +0000
Message-ID: <AM0P192MB0468CC75648CE04D26CF58C3E74C0@AM0P192MB0468.EURP192.PROD.OUTLOOK.COM>
References: <20200706115219.663650-1-john@phrozen.org>
 <20200706115219.663650-6-john@phrozen.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dcf1dc7e-fdf6-4f97-56f8-08d836f5102d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2020 15:02:23.8130
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dSKqcbkRfPdCbvpm0BXns0ZzJ1g6kRxAJ1BPeeR+ahSeI729d64j65afSfr+ZL7vJzRPCASaC0jo64QrJ1Hp2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P192MB0947
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On 06/07/2020 14:52, John Crispin wrote:
> -static void
> +static int
>  ath11k_mac_setup_vdev_create_params(struct ath11k_vif *arvif,
>                                     struct vdev_create_params *params)
>  {
>         struct ath11k *ar =3D arvif->ar;
>         struct ath11k_pdev *pdev =3D ar->pdev;
> +       struct ieee80211_vif *parent;
>
>         params->if_id =3D arvif->vdev_id;
>         params->type =3D arvif->vdev_type;
>         params->subtype =3D arvif->vdev_subtype;
>         params->pdev_id =3D pdev->pdev_id;
> +       params->vdevid_trans =3D 0;
> +       switch (ieee80211_get_multi_bssid_mode(arvif->vif)) {
> +       case NL80211_MULTIPLE_BSSID_TRANSMITTED:
> +               params->flags =3D WMI_HOST_VDEV_FLAGS_TRANSMIT_AP;
> +               break;
> +       case NL80211_MULTIPLE_BSSID_NON_TRANSMITTED:
> +               params->flags =3D WMI_HOST_VDEV_FLAGS_NON_TRANSMIT_AP;
> +               parent =3D ieee80211_get_multi_bssid_parent(arvif->vif);
> +               if (!parent)
> +                       return -ENOENT;
> +               if (ar->hw->wiphy !=3D ieee80211_vif_to_wdev(parent)->wip=
hy)
> +                       return -EINVAL;
> +               params->vdevid_trans =3D ath11k_vif_to_arvif(parent)->vde=
v_id;
> +               break;
> +       default:
> +               params->flags =3D WMI_HOST_VDEV_FLAGS_NON_MBSSID_AP;
> +               break;
> +       }

Hi John,
The ath11k_mac_setup_vdev_create_params() is called from the add_interface =
hook
which is called from ieee80211_do_open() which is, for the first (TRANSMITT=
ED)
interface, before wdev->multi_bssid_mode is set to NL80211_MULTIPLE_BSSID_T=
RANSMITTED
(set upon start_ap from hostapd).
Can you please explain how wdev->multi_bssid_mode can have
NL80211_MULTIPLE_BSSID_TRANSMITTED value in the above code ?

________________________________
The information transmitted is intended only for the person or entity to wh=
ich it is addressed and may contain confidential and/or privileged material=
. Any retransmission, dissemination, copying or other use of, or taking of =
any action in reliance upon this information is prohibited. If you received=
 this in error, please contact the sender and delete the material from any =
computer. Nothing contained herein shall be deemed as a representation, war=
ranty or a commitment by Celeno. No warranties are expressed or implied, in=
cluding, but not limited to, any implied warranties of non-infringement, me=
rchantability and fitness for a particular purpose.
________________________________