Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1460590pxa; Sun, 2 Aug 2020 08:26:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4wfblsiZ1CdpdhE4M3QvUf0UuXLAgkSJRTM1tskh3Rs/XUzfnI8yvJnXr1kW0ojqTlITI X-Received: by 2002:aa7:d8d8:: with SMTP id k24mr12557452eds.32.1596381978601; Sun, 02 Aug 2020 08:26:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596381978; cv=none; d=google.com; s=arc-20160816; b=W9Y9ouwIKoh/huvFk6H6lXgJwjlGyT5DnzSThcS45D6VdFE6ZqVkesdcOf2WRtsYYs J7FxQJWKHI6J4X1EjhAdcRlxsaFtDlWvFXse4+gZtsv6arHXGfbPmtzXjRNK1ERUGTCl u+8NplMA52UZMYNt4ym1XNsyTTubn/lZDaBDJDtzgkcEALqkafHA2lHBjJL+ridpPD9M Ns3dAEpKpJLLhknPXsQD9NkKBlX7OXGwsejKsGUlBzCAiLkKqpx2oE0hpC/VCEeR9ymg 8K8UyqXjUNSOLOkBqUWiV+zkk28YVq0UDcNOD44vxuRzV5RcM5fj5ZOYkerivlZGdtrQ pbSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=DRZV714+whW6bViNi6Hm9eFbR7sbFkMOmAmTc1azI+0=; b=DXgJ6s6b12mZQRwGZZBYT1YJpxjgQsvy/uIUOgDFC/DmAdpLxFp1QPUV36j6aOButG QXYBlfR1XjxGJlc6DSO8dCazp6q3MPf5todCOEwzutkWLEs4QVyx+P3fB/60rK1PymT6 DN0HgeDLHUHL0NKbP0lB0eE7cmyNkeyITsuK7V5sjEs9lhpoNDUw2JL5fL2yDPWu9KQs kADQtHPRPIYBISkifoxxGiiTK6H8Iea9h15zkVfMx436vvkVwkqyXsJfRZDI1EmdL1ug WXcUCjMiRc2Ju0WJcjXkIU0lsQLthA5VxeSrw1ZmjDhtucnqa03NR4Ez+fboGALjPH6f lHZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=fRjzmWw+; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si3016956edv.600.2020.08.02.08.25.55; Sun, 02 Aug 2020 08:26:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=fRjzmWw+; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbgHBPZQ (ORCPT + 99 others); Sun, 2 Aug 2020 11:25:16 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:64601 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbgHBPZQ (ORCPT ); Sun, 2 Aug 2020 11:25:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596381915; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=DRZV714+whW6bViNi6Hm9eFbR7sbFkMOmAmTc1azI+0=; b=fRjzmWw+drc5r2w9kxteqwSpvlmIwpT3ib2lYyrAZ+Gq6EcsMXihgbn0p9Z3/u6JMMg50WWj +C6cNHY2f9D/+0Aif8XQIen4NmD5LeHzv80Fpw/l4eSoNIhlKQBCgZ9D3vR3aDQGcrIg7OS4 NQL6KWGCiSzSkuhmfsBXTyPcrEE= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-east-1.postgun.com with SMTP id 5f26dac8eecfc978d39f071d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 02 Aug 2020 15:24:56 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 495EEC433A0; Sun, 2 Aug 2020 15:24:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9C676C433C6; Sun, 2 Aug 2020 15:24:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9C676C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v1] airo: use generic power management From: Kalle Valo In-Reply-To: <20200728114128.1218310-1-vaibhavgupta40@gmail.com> References: <20200728114128.1218310-1-vaibhavgupta40@gmail.com> To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , "David S. Miller" , Jakub Kicinski , Dan Carpenter , Vaibhav Gupta , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200802152455.495EEC433A0@smtp.codeaurora.org> Date: Sun, 2 Aug 2020 15:24:55 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct dev_pm_ops" variable to take the unnecessary load from the driver. > This also avoids the need for the driver to directly call most of the PCI > helper functions and device power state control functions, as through > the generic framework PCI Core takes care of the necessary operations, > and drivers are required to do only device-specific jobs. > > Signed-off-by: Vaibhav Gupta Patch applied to wireless-drivers-next.git, thanks. c3ab1804b168 airo: use generic power management -- https://patchwork.kernel.org/patch/11688983/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches