Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1909438pxa; Mon, 3 Aug 2020 02:17:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+WmSEB7F23vNgMiGl8uX9KUzWzeQJM6CwhNAVkRmVz015Gezv1hiYdpOEQMzPV3KjPdvg X-Received: by 2002:a05:6402:17f7:: with SMTP id t23mr15041733edy.301.1596446225508; Mon, 03 Aug 2020 02:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596446225; cv=none; d=google.com; s=arc-20160816; b=FaqbQ9LTerS9kqnpaZAeLcVi7ZF7HKMldwCtHyPgQuSY9P1no3ZxLcI/XeXFUh1kbT IWUZy8N6cY1sSym49S8cZMRKJlqQwZIvOFWNmt1AhULWhRfaV89P6sa26hrEyxTlyiPR PCsUFl/qvULFk4naAvtYrKA34ZM+YJ6vhjjB/MPWBJeJkMUMP5sOJFQhfxUEsOwF6E3m CSP8ycYUByZHDKk4qQeTH+u4hmDeYuPMxnbWHwY7cI0suBv6AQf2ku271mJZfefddt/7 jb8i+h6URhshu1oBCR5B6cV0/PL4hBBscrn0TS3PWQDLOv4KXH87M6EJWlvDe0pFnK93 4nAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ZGhiRg5z9PEzNKpZ6Zh/5oB+kR9T494+seCGHlKRCBw=; b=e4JKzOfZfrJT3CS6pNq6ckYcjknbz1Ma7EKZnr/Je/146b/OGsSZIct7APFBdtwlAF QslCdhxHpcPxmp8oN7tUkWZIbNiq9pgj1+DzC0WGaWJunLA2PMv2essMLk+o9dLI0YAD dOEork7nfxJM+hoGq6fvwPVjB4tFrNGeFtfdmv7mghks1yNoRDhHfdZlxQR+AE6b8zjv IgE28ZeMnW5yI6o+ANJwdUmhHEhuRe0c+R8ts1epp8cFiW/danBRBw6T2YXHQkNH1D6Q 7PJnsmle/3xK8MlAVtl82QQXe1gGsOMD4kZ2HsKfEy8+k7Dsh1eg0KLFYCr21swx8et6 bTWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu23si5204148edb.440.2020.08.03.02.16.41; Mon, 03 Aug 2020 02:17:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgHCJP7 (ORCPT + 99 others); Mon, 3 Aug 2020 05:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgHCJP7 (ORCPT ); Mon, 3 Aug 2020 05:15:59 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CD4C06174A for ; Mon, 3 Aug 2020 02:15:59 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1k2WZZ-00FbMm-EY; Mon, 03 Aug 2020 11:15:57 +0200 Message-ID: Subject: Re: [PATCH V5 2/3] mac80211: add support for setting fixed HE rate/gi/ltf From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Miles Hu Date: Mon, 03 Aug 2020 11:15:41 +0200 In-Reply-To: <20200803085127.180550-2-john@phrozen.org> References: <20200803085127.180550-1-john@phrozen.org> <20200803085127.180550-2-john@phrozen.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-08-03 at 10:51 +0200, John Crispin wrote: > From: Miles Hu > > With nl80211 now able to receive fixed HE rate/gi/ltf settings we want to > propagate these further down the stack into the mac80211 drivers. This > patch copies the values into the sdata struct. I do not see any reason for this patch, copying data to a mac80211 internal structure and then not using it does ... nothing. Dropped this patch. johannes