Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 03 Aug 2020 10:30:55 -0700
From:   Aloka Dixit <alokad@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response
 support
In-Reply-To: <6f23e2ac081a3960959f00dedcdf8795aef28a14.camel@sipsolutions.net>
References: <20200715230514.26792-1-alokad@codeaurora.org>
 <20200715230514.26792-2-alokad@codeaurora.org>
 <6f23e2ac081a3960959f00dedcdf8795aef28a14.camel@sipsolutions.net>
Message-ID: <1aca682f4b694c5ea3d1c57291e6c196@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-08-03 03:20, Johannes Berg wrote:
> Also,
> 
>> +/**
>> + * enum nl80211_unsol_bcast_probe_resp_attributes - Unsolicited 
>> broadcast probe
>> + *	response configuration. Applicable only in 6GHz.
>> + *
>> + * @__NL80211_UNSOL_BCAST_PROBE_RESP_INVALID: Invalid
>> + *
>> + * @NL80211_UNSOL_BCAST_PROBE_RESP_INT: Maximum packet interval (u32, 
>> TU).
>> + *	Allowed range: 0..20 (TU = Time Unit). IEEE P802.11ax/D6.0
> 
> 0 doesn't make sense, you should disallow that.
> 
> I see you used it for "turn off" at least in the mac80211 patch but it
> seems to me that should have a more explicit way at least in the
> external API? At the very least it needs to documentation.
> 
> johannes


Hi Johannes, interval=0 means 'disable' is given in the specification, 
will extend the documentation to mention that.